Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mockito and all related features #136

Closed
wants to merge 1 commit into from

Conversation

rubengees
Copy link
Contributor

@rubengees rubengees commented Feb 11, 2019

Since I also suffered from long autocompletion lists (I mainly use mockk), I decided to remove the dependency on Mockito and all related features as outlined in #73.

Thus this would fix #73.

  • I've added my name to the AUTHORS file, if it wasn't already present.

@rubengees
Copy link
Contributor Author

I have seen that Spek should also be removed for 2.0. Should I do this as part of this PR? Or open a new one? Also, Spek does not seem to be an api dependency, what is the rationale for removing it?

@@ -21,12 +19,9 @@ dependencies {
testImplementation libs.kotlin_test_jvm
testImplementation libs.kotlin_test_junit


// TODO: To be removed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this? Is this related only to Mockito and Spek?

@MarkusAmshove
Copy link
Owner

Thank you for the PR :)

I still have to figure out what the right approach is for these big changes, as they will clearly break code.
I'm leaning into having a 1.x branch for the "old" stuff while 2.0 having as much Deprecated annotations with codefixes as possible and then removing the stuff in 2
1.

As for Spek, you shouldn't have to worry about it, because it should only be present in backtick tests.

I wanted to remove Spek to have all the tests following the same format, as Spek is jvm only.

@rubengees
Copy link
Contributor Author

Hmm, I would propose to have a 1.x branch (and a new release 1.5 soon) with everything this PR removes marked as @Deprecated and keep the master branch as the baseline for 2.x (which then removes all this). I can help with the former if you like :)

Ah I see, can I help with the removal of Spek? That could be done right now since that is no public API in any way.

@MarkusAmshove
Copy link
Owner

Converting Spek to kotlin.test is something I would do in a separate PR, because it isn't user facing and can easily be merged now.

If you want to go for it, don't hesitate :-)

@MarkusAmshove
Copy link
Owner

I've now removed Spek everywhere, so we're getting close :-)

@rubengees
Copy link
Contributor Author

Sorry, totally forgot about this! Is there something remaining to be done?

@MarkusAmshove
Copy link
Owner

Hi, as the mocking feature is still used and even improved (there's currently a PR for it), I'm currently rethinking this approach. It might be better to pull it out into its own artifact, so instead of losing the functionality, people can add another artifact and their tests aren't broken

@rubengees
Copy link
Contributor Author

Okay, that sounds like a good option too.
I'll close this PR then.

@rubengees rubengees closed this Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate mocking-related features
2 participants