Skip to content

Commit 9ba1609

Browse files
authored
Merge pull request #5 from MarletteFunding/feature/data-2608
Feature/data 2608
2 parents 3928e68 + 2596469 commit 9ba1609

File tree

6 files changed

+28
-16
lines changed

6 files changed

+28
-16
lines changed

.circleci/config.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
command: |
2222
python3 -mvenv /usr/local/share/virtualenvs/tap-google-ads
2323
source /usr/local/share/virtualenvs/tap-google-ads/bin/activate
24-
pip install 'pip==21.1.3'
24+
pip install 'pip==23.3.2'
2525
pip install 'setuptools==56.0.0'
2626
pip install .[dev]
2727
- slack/notify-on-failure:
@@ -57,9 +57,8 @@ jobs:
5757
name: 'Run Unit Tests'
5858
command: |
5959
source /usr/local/share/virtualenvs/tap-google-ads/bin/activate
60-
pip install nose coverage
61-
nosetests --with-coverage --cover-erase --cover-package=tap_google_ads --cover-html-dir=htmlcov tests/unittests
62-
coverage html
60+
pip install nose2
61+
nose2 -v -s tests/unittests
6362
- store_test_results:
6463
path: test_output/report.xml
6564
- store_artifacts:

.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
/.idea
2+
__pycache__/
3+
tap_google_ads.egg-info/

CHANGELOG.md

+9
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,13 @@
11
# Changelog
2+
3+
## v1.7.0
4+
* Run on python 3.11.7 [#88](https://github.com/singer-io/tap-google-ads/pull/88)
5+
6+
## v1.6.0
7+
* Updates API version to 15
8+
* Updates pkg version to 22.1.0
9+
* [#86](https://github.com/singer-io/tap-google-ads/pull/86)
10+
211
## v1.5.0
312
* Updates API version to 13
413
* Updates pkg version to 21.0.0

setup.py

+7-6
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,22 @@
33
from setuptools import setup
44

55
setup(name='tap-google-ads',
6-
version='1.5.0',
6+
version='1.7.0',
77
description='Singer.io tap for extracting data from the Google Ads API',
88
author='Stitch',
99
url='http://singer.io',
1010
classifiers=['Programming Language :: Python :: 3 :: Only'],
1111
py_modules=['tap_google_ads'],
1212
install_requires=[
13-
'singer-python==5.12.2',
13+
'singer-python==6.0.0',
1414
'requests==2.26.0',
15-
'backoff==1.8.0',
16-
'google-ads==21.2.0',
17-
'protobuf==4.22.3',
15+
'backoff==2.2.1',
16+
'google-ads==23.1.0',
17+
'protobuf==4.25.0',
18+
1819
# Necessary to handle gRPC exceptions properly, documented
1920
# in an issue here: https://github.com/googleapis/python-api-core/issues/301
20-
'grpcio-status==1.44.0',
21+
'grpcio-status==1.59.0',
2122
],
2223
extras_require= {
2324
'dev': [

tap_google_ads/report_definitions.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -1729,11 +1729,11 @@
17291729
"segments.external_conversion_source",
17301730
"segments.month",
17311731
"segments.product_aggregator_id",
1732-
"segments.product_bidding_category_level1",
1733-
"segments.product_bidding_category_level2",
1734-
"segments.product_bidding_category_level3",
1735-
"segments.product_bidding_category_level4",
1736-
"segments.product_bidding_category_level5",
1732+
"segments.product_category_level1",
1733+
"segments.product_category_level2",
1734+
"segments.product_category_level3",
1735+
"segments.product_category_level4",
1736+
"segments.product_category_level5",
17371737
"segments.product_brand",
17381738
"segments.product_channel",
17391739
"segments.product_channel_exclusivity",

tap_google_ads/streams.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
LOGGER = singer.get_logger()
1616

17-
API_VERSION = "v14"
17+
API_VERSION = "v16"
1818

1919
API_PARAMETERS = {
2020
"omit_unselected_resource_names": "true"

0 commit comments

Comments
 (0)