Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWEST BLTOUCH NEEDS INVERSION OPTIONS #13878

Closed
Aurawin opened this issue May 2, 2019 · 4 comments
Closed

NEWEST BLTOUCH NEEDS INVERSION OPTIONS #13878

Aurawin opened this issue May 2, 2019 · 4 comments

Comments

@Aurawin
Copy link

Aurawin commented May 2, 2019

Description

Recently purchased newest authentic BLTouch from Amazon. I had problems with halting error because Z-min was always triggered. After much research, I found the M43 S tool which indicated that inversion was likely needed.

I inverted both z-min and probe-z-min invertion = true (previously always false) and eventually realized that the conditionals_lcd.h was overriding my explicit directives. Which at least on this new BLTouch is THE PROBLEM.

Steps to Reproduce

Issue G34 and error persists even if I follow suggested probe instructions to invert signal.

Expected behavior: [What you expect to happen]

Firmware should do as the configuration calls for and assume person editing these settings does so purposely.

Actual behavior: [What actually happens]

Conditionals_LCD.h overrides Configuration.h values for Z-MIN inverting

Additional Information

I quickly edited the BLTouch block in Conditionals_LCD.h / flashed / and M43 S returned with expected results. i.e.) no more inversion suggestions.

// Always disable probe pin inverting for BLTouch
#undef Z_MIN_PROBE_ENDSTOP_INVERTING
#define Z_MIN_PROBE_ENDSTOP_INVERTING true
#if ENABLED(Z_MIN_PROBE_USES_Z_MIN_ENDSTOP_PIN)
#undef Z_MIN_ENDSTOP_INVERTING
#define Z_MIN_ENDSTOP_INVERTING true
#endif

Please remove the need to hack Conditionals_LCD.h with this code. It is going to be a BIG problem for ppl who just need Marlin to do what we programmed it to do.

For reference I had to define PINS_DEBUGGING in Configuration_adv.h and DEBUG_LEVELING_FEATURE in Configuration.h

@Aurawin Aurawin changed the title NEWEST BLTOUCH NOT WORKING NEWEST BLTOUCH NEEDS INVERSION OPTIONS May 2, 2019
@Roxy-3D
Copy link
Member

Roxy-3D commented May 2, 2019

You might want to review some of the BL-Touch v3.0 threads:

#13345

#13841

#13814

@InsanityAutomation
Copy link
Contributor

Its forced with the BLTouch by design because thats what it requires to function correctly. As many miss that step when using the z probe on the z min input, that automatic set was added. The behavior is correct and I wouldnt agree with changing it unless a bltouch like clone with logic functionally different appears. It would just be one more variable we would get support requests about when somebody misses it....

@Roxy-3D
Copy link
Member

Roxy-3D commented May 2, 2019

It would just be one more variable we would get support requests about when somebody misses it....

Agreed. There has to be a 'real' need for it before it will happen.

@Roxy-3D Roxy-3D closed this as completed May 2, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants