Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Can't set EXTRUDER_AUTO_FAN_SPEED != 255 #15857

Closed
BastR opened this issue Nov 9, 2019 · 17 comments
Closed

[BUG] Can't set EXTRUDER_AUTO_FAN_SPEED != 255 #15857

BastR opened this issue Nov 9, 2019 · 17 comments

Comments

@BastR
Copy link
Contributor

BastR commented Nov 9, 2019

Description

SKR PRO is a board that is capable of hosting 3 extruders, so it has 3 PWM outputs for extruders fans (FAN0, FAN1, FAN2). I only have one extruder but I use the 3 FAN outputs this way:

-FAN0 is the extruder fan
-FAN1 is the hotend fan that is declared with E0_AUTO_FAN_PIN
-FAN2 is the board fan that is declared with USE_CONTROLLER_FAN

I want to set FAN1 (E0_AUTO_FAN_PIN) with a value other than 255 for EXTRUDER_AUTO_FAN_SPEED but Sanitycheck.h does not allow it:

Configuration_adv.h

// @section extruder

/**
 * Extruder cooling fans
 *
 * Extruder auto fans automatically turn on when their extruders'
 * temperatures go above EXTRUDER_AUTO_FAN_TEMPERATURE.
 *
 * Your board's pins file specifies the recommended pins. Override those here
 * or set to -1 to disable completely.
 *
 * Multiple extruders can be assigned to the same pin in which case
 * the fan will turn on when any selected extruder is above the threshold.
 */
#define E0_AUTO_FAN_PIN FAN1_PIN
#define E1_AUTO_FAN_PIN -1
#define E2_AUTO_FAN_PIN -1
#define E3_AUTO_FAN_PIN -1
#define E4_AUTO_FAN_PIN -1
#define E5_AUTO_FAN_PIN -1
#define CHAMBER_AUTO_FAN_PIN -1

#define EXTRUDER_AUTO_FAN_TEMPERATURE 50
#define EXTRUDER_AUTO_FAN_SPEED 127   // 255 == full speed
//#define CHAMBER_AUTO_FAN_TEMPERATURE 30
//#define CHAMBER_AUTO_FAN_SPEED 255

SanityCheck.h

/**
 * Auto Fan check for PWM pins
 */
#if HAS_AUTO_FAN && EXTRUDER_AUTO_FAN_SPEED != 255
  #define AF_ERR_SUFF "_AUTO_FAN_PIN is not a PWM pin. Set EXTRUDER_AUTO_FAN_SPEED to 255."
  #if HAS_AUTO_FAN_0
    static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF);
  #elif HAS_AUTO_FAN_1
    static_assert(PWM_PIN(E1_AUTO_FAN_PIN), "E1" AF_ERR_SUFF);
  #elif HAS_AUTO_FAN_2
    static_assert(PWM_PIN(E2_AUTO_FAN_PIN), "E2" AF_ERR_SUFF);
  #elif HAS_AUTO_FAN_3
    static_assert(PWM_PIN(E3_AUTO_FAN_PIN), "E3" AF_ERR_SUFF);
  #endif
#endif

I've commented out all the lines above and I can compile, I've tried 127 and 63 instead of 255 and all values works.

I don't understand why it is allowed to set a different fan speed if SanityCheck will systematically reject it. I don't have the coding knowledge but it should be possible to set another fan speed value if the board has PWM outputs or if the user makes some tweaks (with Ramps fan extender or similar)

English is not my first language, I hope to make myself understood
@sjasonsmith
Copy link
Contributor

Could you try this using the branch from the following open PR? There were some PWM issues on the SKR Pro that are resolved as part of these changes.
#15655

@LinoBarreca
Copy link
Contributor

The PR mentioned above by @sjasonsmith correctly sets the PWM pins in the board variant. so please try it. iwhatever the result is let us know.

@BastR
Copy link
Contributor Author

BastR commented Nov 9, 2019

Same error with #define EXTRUDER_AUTO_FAN_SPEED 106, if I let 255 I compile without error, juste warnings :

In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/timers.h:25, from Marlin/src/HAL/HAL_STM32/HAL.h:99, from Marlin/src/HAL/HAL_STM32/HAL.cpp:26: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/HAL.cpp:26: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/HAL_SPI.cpp:25: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/HAL.h:26, from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:30, from Marlin/src/HAL/HAL_STM32/HAL_SPI.cpp:25: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/Servo.cpp:25: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/HAL.h:26, from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:30, from Marlin/src/HAL/HAL_STM32/Servo.cpp:25: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/fastio.cpp:25: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/HAL.h:26, from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:30, from Marlin/src/HAL/HAL_STM32/fastio.cpp:25: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/HAL.cpp.o] Error 1 *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/HAL_SPI.cpp.o] Error 1 In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/persistent_store_impl.cpp:25: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/HAL.h:26, from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:30, from Marlin/src/HAL/HAL_STM32/persistent_store_impl.cpp:25: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/persistent_store_sdcard.cpp:29: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/../../inc/../HAL/HAL.h:26, from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:30, from Marlin/src/HAL/HAL_STM32/persistent_store_sdcard.cpp:29: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/../HAL/./HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/Servo.cpp.o] Error 1 *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/fastio.cpp.o] Error 1 In file included from Marlin/src/HAL/HAL_STM32/persistent_store_impl.cpp:32:0: /Users/bastien/.platformio/packages/framework-arduinoststm32/libraries/EEPROM/src/EEPROM.h:247:20: warning: 'EEPROM' defined but not used [-Wunused-variable] static EEPROMClass EEPROM; ^~~~~~ *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/persistent_store_impl.cpp.o] Error 1 *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/persistent_store_sdcard.cpp.o] Error 1 In file included from Marlin/src/HAL/HAL_STM32/../../inc/MarlinConfig.h:38:0, from Marlin/src/HAL/HAL_STM32/timers.h:25, from Marlin/src/HAL/HAL_STM32/HAL.h:99, from Marlin/src/HAL/HAL_STM32/timers.cpp:25: Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:5: error: non-constant condition for static assertion static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~~~~~~~ In file included from /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/Arduino.h:48:0, from Marlin/src/HAL/HAL_STM32/../shared/Marduino.h:36, from Marlin/src/HAL/HAL_STM32/HAL.h:28, from Marlin/src/HAL/HAL_STM32/timers.cpp:25: /Users/bastien/.platformio/packages/framework-arduinoststm32/cores/arduino/pins_arduino.h:254:51: error: call to non-constexpr function 'bool pin_in_pinmap(PinName, const PinMap*)' #define digitalPinHasPWM(p) (pin_in_pinmap(digitalPinToPinName(p), PinMap_PWM)) ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/fastio.h:83:33: note: in expansion of macro 'digitalPinHasPWM' #define PWM_PIN(P) digitalPinHasPWM(P) ^~~~~~~~~~~~~~~~ Marlin/src/HAL/HAL_STM32/../../inc/SanityCheck.h:1854:19: note: in expansion of macro 'PWM_PIN' static_assert(PWM_PIN(E0_AUTO_FAN_PIN), "E0" AF_ERR_SUFF); ^~~~~~~ *** [.pio/build/BIGTREE_SKR_PRO/src/src/HAL/HAL_STM32/timers.cpp.o] Error 1

@LinoBarreca
Copy link
Contributor

please attach config files (standard and advanced). I guess you found another bug.

@LinoBarreca
Copy link
Contributor

no wait. I found the problem. config files aren't needed.

@BastR
Copy link
Contributor Author

BastR commented Nov 9, 2019

Ok

@LinoBarreca
Copy link
Contributor

@sjasonsmith Problem here is that STM32 don't have real "PWM pins". every digital pin can be defined as PWM. to check if a pin is actually defined as PWM you gotta make a loop. so a STATIC ASSERT (at compile time) can't be done. I'm opening a proper issue about this.

@LinoBarreca LinoBarreca mentioned this issue Nov 9, 2019
Closed
@LinoBarreca
Copy link
Contributor

@BastR I am sorry to say that you gotta wait for that.
We first need to merge #15655 then I'll take care of fixing your problem with the bug #15858

@BastR
Copy link
Contributor Author

BastR commented Nov 9, 2019

@BastR I am sorry to say that you gotta wait for that.
We first need to merge #15655 then I'll take care of fixing your problem with the bug #15858

No problem, I can wait. Thanks for your work ;)

@BastR
Copy link
Contributor Author

BastR commented Nov 10, 2019

@LinoBarreca I'm running your branch now, I've made more test today. It seems I've an issues with the extruder fan too (PLA cooler). If I set fan to 50% from the LCD, he clearly not spins at 50%, he stay very close to 100%. I have measured the supplied voltage at various speed values:

100% - 12V
50% - 11,2V
20% - 10,5V
1% - 5,2V

It's not related to your branch, I've put a previous build and this problem is already present.

@BlackMelt
Copy link

BlackMelt commented Nov 10, 2019 •
edited
Loading

Hi there,
same issue here.

SKR Pro with 1 Extruder set on Pin PB1
1 Coldend Fan set on Pin PC8
1 Part Colling Fan on Pin PE5

I try'd to compile with #define Extruder_Auto_Fan_Speed 127

and this error shows up https://pastebin.com/xuEYkyEX

This was just to verify the issue from BastR

Thank you all for your Help,
Greetings from Germany
Mathias

@BastR
Copy link
Contributor Author

BastR commented Nov 10, 2019

@BlackMelt can you try something for me please, try to set your part cooling fan to 50% with your LCD and tell me if you hear clearly your fan slowing. As explained above mine doesn’t low his speed, it’s just to know if it’s hardware or software.

Thanks you

@BlackMelt
Copy link

@BastR So my stepps ware fallowing:
1: Set the Nozzle to <50 °C (to start the Coldend Fan)
2: Set the Part Cooling fan to 50
3: nothing changed even if i hold manualy the Fan Rotors to ensure the same noise Lvl.

Hope this Bug gets Fixed, my ColdendFan is to Powerfull.

Greez

@LinoBarreca
Copy link
Contributor

LinoBarreca commented Nov 10, 2019 •
edited
Loading

As regards the build error I already opened a bug with technical details which will help someone solve the problem.
As regards the "uncorrect fan speed", to check if it's a software or hardware problem, you need to:

if you have a square, 1kHz, 50% duty cycle, wave the software is ok.
Measure it again on the fan connector. if you see the same wave (but at a higher voltage) the hardware is ok.

@salacpavel
Copy link

#15362

@LinoBarreca
Copy link
Contributor

this should be closed as duplicate.

@BastR BastR closed this as completed Nov 13, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LinoBarreca @sjasonsmith @BastR @salacpavel @BlackMelt