Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Vietnamese language files contains defunct string names #15937

Closed
ellensp opened this issue Nov 18, 2019 · 4 comments
Closed

[BUG] Vietnamese language files contains defunct string names #15937

ellensp opened this issue Nov 18, 2019 · 4 comments

Comments

@ellensp
Copy link
Contributor

ellensp commented Nov 18, 2019

Description

language_vi.h contains defunct string names as of #14951
Contains MSG_CARD_MENU and MSG_NO_CARD should have MSG_MEDIA_MENU and MSG_NO_MEDIA
Contains MSG_SD_INSERTED and MSG_SD_REMOVED should have MSG_MEDIA_INSERTED and MSG_MEDIA_REMOVED
Contains MSG_INIT_SDCARD and MSG_CHANGE_SDCARD should have MSG_INIT_MEDIA and MSG_CHANGE_MEDIA
Contains MSG_SD_UPDATE should have MSG_MEDIA_UPDATE

Although i'm sure this causes an error somewhere I didn't find it this way so there are no config files.

Just go look at the file.

@boelle
Copy link
Contributor

boelle commented Nov 18, 2019

are you using bugfix 2.0.x ?

@GMagician
Copy link
Contributor

In languages, missing defines will not raise an error, Marlin will simply switch to English version.

@shitcreek
Copy link
Contributor

I've created a PR for this. Thanks for pointing it out.

@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants