-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Marlin Bugfix fails to compile after #18724 and #18730 updates #18739
Comments
I just downloaded 2119e19 and was able to compile the code successfully. |
@Lord-Quake 2119e19 is the same version that would not compile for me. It is likely that the dependency was already resolved in your environment. I was not so lucky. This problem has not cropped up in prior versions. Additionally, I tried following the link and installed U8glib library (the one without HAL on the end). It made no difference. |
Can you show the top of the compiler log where it builds the dependency graph. |
U8glib only will be installed and used if So I think one of two thing might be happening:
Are you using the last bugfix? There're more than one PR about the new build that was just merged. I will test your configs too. |
Using his configs:
|
@rhapsodyv Yes very latest build. my controller/LCD @p3p Sure:
|
@ellensp Why would it need it now and not before? I am not doubting you but it just does not seem right. How would it be installed? |
Looks like REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER isn’t defining HAS_GRAPHICAL_LCD, but depends on U8glib. |
@bill-orange
|
Sorry took me a second to get set up on windows to test this, your compile logs don't appear to be correct for the latest bugfix, when I build you see the feature detection script running as it should, I don't see it at all on yours.
|
Hum... Bingo!! I didn't see it!! But yes, you are correct. This lines must appear with last commits:
and
If those lines want showing, or isnt the lasts commits, or the user env was edited and isn't including the common.extra_scripts. |
Ah, your |
If those lines want showing, or isnt the lasts commits, or the user env was edited and isn't including the common.extra_scripts. |
Yep, I fell for it too. Should have checked that he is using the latest platformio.ini :-/ My test compiles successfully now. However I have this now:
|
@Lord-Quake The platformio.ini file was the first thing I checked, but I fell for the trap that the top lines looked correct having the new extra_script definitions, should have looked closer. That looks fine?, Unless you have a drive with a `firmware.cur" file in the root it can't autodetect the upload directory. |
Must be something to do with "default_envs = LPC1768". I've never compiled this before. |
@rhapsodyv , @Lord-Quake , @p3p I am not sure how my PlatformIO could be outdated. I thought Github Desktop Merge into Current Branch took care of those details. That's neither here nor there, I suppose. In VSCODE I deleted the contents of the old PlatformIO content and pasted in the new content out of the Marlin Github site and changed my default_envs to LPC1768. Crude but effective. Now I can successfully compile. Do you suppose something needs to be added to Sanity Check for this? |
There isn't really a good way to detect an out if date or corrupted/modified platformio.ini, and if we did add a method for that it would probably use the scripts that were disabled by the merge corruption in your case so wouldn't have helped. You have to be careful using git merges, I've never used github desktop so don't know what it does but you don't really want to merge the remote bugfix branch into your local copy to update, you should have a branch for your config and when you want to update you reset your local bugfix branch to origin then rebase your config branch on that.. but if you're unfamiliar with git just downloading a new zip may be easier. |
Resolved. Closing |
I'm not sure how easy rebasing in GitHub Desktop is, but it's literally drag and drop in GitKraken if you want to stick with a GUI client. @bill-orange: You'll likely want to start with a fresh copy of |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Bug Description: After updates #18724 and #18730 Marlin fails to compile due to unsatisfied dependencies. VSCODE was used in a Windows 10 environment. Here is the error:
My Configurations: Attached
Marlin.zip
Steps to Reproduce
Expected behavior: Successful resolution of dependencies and compilation
Actual behavior: Failure to resolve dependencies and failure to compile
Additional Information: A brief look in Libraries shows that U8glib-HAL is present which appears to also contain U8glib-ARM. These apparently do not resolve the dependency.
The text was updated successfully, but these errors were encountered: