Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREHEAT_2_* seems broken on bugfix-2.0.x #18742

Closed
shawe opened this issue Jul 21, 2020 · 4 comments
Closed

PREHEAT_2_* seems broken on bugfix-2.0.x #18742

shawe opened this issue Jul 21, 2020 · 4 comments

Comments

@shawe
Copy link

shawe commented Jul 21, 2020

Bug Description

On printer menu always appear text PREHEAT_1_LABEL also for PREHEAT_2_LABEL, this seems to be only reproducible on bugfix-2.0.x for at least a week. The temperatures are changing according to PREHEAT_1 or PREHEAT_2, but text messages aren't the correct.

My Configurations

Required: Please include a ZIP file containing your Configuration.h and Configuration_adv.h files.

For me seems to not be related to a configuration problem.

MKS Robin E3 BMG.zip

Steps to Reproduce

  1. Compile
  2. Update the firmware printer
  3. Go to: Temperature an scroll down, Preheat PLA, scroll a little more and there are again a Preheat PLA
  4. There is not PTG (or ABS), only PLA

Expected behavior: [What you expect to happen]

  1. Compile
  2. Update the firmware printer
  3. Go to: Temperature an scroll down, Preheat PLA, scroll a little more and there are Preheat PTG (or ABS)

Actual behavior: [What actually happens]

  1. Compile
  2. Update the firmware printer
  3. Go to: Temperature an scroll down, Preheat PLA, scroll a little more and there are again a Preheat PLA
  4. There is not PTG (or ABS), only PLA

On stable version 2.0.x:

  1. Compile
  2. Update the firmware printer
  3. Go to: Temperature an scroll down, Preheat PLA, scroll a little more and there are Preheat PTG (or ABS)

Additional Information

  • Provide pictures or links to videos that clearly demonstrate the issue.
  • See How Can I Contribute for additional guidelines.

3bc36f16-4263-4717-af99-20c91df6d1ef

@thisiskeithb
Copy link
Member

thisiskeithb commented Jul 22, 2020

Replace Marlin/src/lcd/language/language_es.h with the language_es.h from the .zip:
language_es.h.zip

Or you can manually edit language_es.h & change the following:

PROGMEM Language_Str MSG_PREHEAT_1 = _UxGT("Precal. $");
PROGMEM Language_Str MSG_PREHEAT_1_H = _UxGT("Precal. $ ~");
PROGMEM Language_Str MSG_PREHEAT_1_END = _UxGT("Precal. $ Fusor");
PROGMEM Language_Str MSG_PREHEAT_1_END_E = _UxGT("Precal. $ Fusor ~");
PROGMEM Language_Str MSG_PREHEAT_1_ALL = _UxGT("Precal. $ Todo");
PROGMEM Language_Str MSG_PREHEAT_1_BEDONLY = _UxGT("Precal. $ Cama");
PROGMEM Language_Str MSG_PREHEAT_1_SETTINGS = _UxGT("Precal. $ Ajuste");
PROGMEM Language_Str MSG_PREHEAT_M = _UxGT("Precal. ") PREHEAT_1_LABEL;
PROGMEM Language_Str MSG_PREHEAT_M_H = _UxGT("Precal. ") PREHEAT_1_LABEL " ~";
PROGMEM Language_Str MSG_PREHEAT_M_END = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Fusor");
PROGMEM Language_Str MSG_PREHEAT_M_END_E = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Fusor ~");
PROGMEM Language_Str MSG_PREHEAT_M_ALL = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Todo");
PROGMEM Language_Str MSG_PREHEAT_M_BEDONLY = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Cama");
PROGMEM Language_Str MSG_PREHEAT_M_SETTINGS = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Ajuste");

to:

    PROGMEM Language_Str MSG_PREHEAT_1                     = _UxGT("Precal. ") PREHEAT_1_LABEL;
    PROGMEM Language_Str MSG_PREHEAT_1_H                   = _UxGT("Precal. ") PREHEAT_1_LABEL " ~";
    PROGMEM Language_Str MSG_PREHEAT_1_END                 = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Fusor");
    PROGMEM Language_Str MSG_PREHEAT_1_END_E               = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Fusor ~");
    PROGMEM Language_Str MSG_PREHEAT_1_ALL                 = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Todo");
    PROGMEM Language_Str MSG_PREHEAT_1_BEDONLY             = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Cama");
    PROGMEM Language_Str MSG_PREHEAT_1_SETTINGS            = _UxGT("Precal. ") PREHEAT_1_LABEL _UxGT(" Ajuste");

    PROGMEM Language_Str MSG_PREHEAT_M                    = _UxGT("Precal. $");
    PROGMEM Language_Str MSG_PREHEAT_M_H                  = _UxGT("Precal. $ ~");
    PROGMEM Language_Str MSG_PREHEAT_M_END                = _UxGT("Precal. $ Fusor");
    PROGMEM Language_Str MSG_PREHEAT_M_END_E              = _UxGT("Precal. $ Fusor ~");
    PROGMEM Language_Str MSG_PREHEAT_M_ALL                = _UxGT("Precal. $ Todo");
    PROGMEM Language_Str MSG_PREHEAT_M_BEDONLY            = _UxGT("Precal. $ Cama");
    PROGMEM Language_Str MSG_PREHEAT_M_SETTINGS           = _UxGT("Precal. $ Ajuste");

@thisiskeithb
Copy link
Member

The fix has now been merged into bugfix-2.0.x, so you don't have to edit files/replace text as long as you pull down a fresh copy.

@shawe
Copy link
Author

shawe commented Jul 22, 2020

This was so fast ;)

I don't tested yet, but yes, seems to be this the problem because in other languages are the same.

Yesterday was too late for me when I see the problem, for try to look a little for the problem and suggest anything, and while I'm sleeping you found it and solve it.

Thanks for the fix

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants