Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistencies in autobuild/dependencies script #18900

Closed
Marlor opened this issue Aug 2, 2020 · 6 comments
Closed

[BUG] Inconsistencies in autobuild/dependencies script #18900

Marlor opened this issue Aug 2, 2020 · 6 comments

Comments

@Marlor
Copy link

Marlor commented Aug 2, 2020

Found 2 potential bugs in the dependencies script/autobuild

This is the output of a cleen unchanged marlin bugfix-2.0.x configuration:

Found 5 compatible libraries
Scanning dependencies...
Dependency Graph
|-- <Wire> 1.0
|-- <SPI> 1.0
|-- <EEPROM> 2.0
|-- <SoftwareSerial> 1.0
Building in release mode
[...]

Found 5 and only using 4?

Only changing MOTHERBOARD to BOARD_BTT_SKR_V1_3 gives this output:

Found 3 compatible libraries
Scanning dependencies...
Dependency Graph
|-- <Servo> 1.0.0
|-- <LiquidCrystal> 1.0.0
|-- <Adafruit NeoPixel> 1.5.0
Building in release mode
[...]

Found 3 and using 3, but is NeoPixel always needet on an SKR V1.3?

@ellensp
Copy link
Contributor

ellensp commented Aug 2, 2020

If don't get libraries it needs it will fail to compile.
If you add in extra they are just ignored.

In the case of the LPC1768/9 it needs a special version of neopixel library.
So it is always added in case it is needed.
It is in the platformio.ini
[common_LPC]
lib_deps Adafruit NeoPixel=https://github.com/p3p/Adafruit_NeoPixel/archive/1.5.0.zip

If this was left to the auto detection script it would only include neopixel library when it is needed, but it would use the standard neopixel library that doesn't work on lpc1768/9

These are questions. not bugs..

This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

After seeking help from the community, if the consensus points to a bug in Marlin, then you should post a bug report.

@ellensp ellensp closed this as completed Aug 2, 2020
@Marlor
Copy link
Author

Marlor commented Aug 2, 2020

These are questions. not bugs..

The feature: #18699 "Optimize build. Only used libraries downloaded & compiled."
The reality: downloades & compiles unused libraries on lpc1768/9
Please tell me you can see how this can be interpreted as a bug

Its a new feature so i rather reported than ignore it.
These reports are not welcome here? Maybe you should add this info in the docs

@ellensp
Copy link
Contributor

ellensp commented Aug 2, 2020

you did read my reply

the LPC1768 overrides this new feature for neopixels, as it has to!

@Marlor
Copy link
Author

Marlor commented Aug 2, 2020

I know, that wasn't what my reply was about

@thinkyhead
Copy link
Member

"Found 5 compatible libraries"

A message from PlatformIO, perhaps …before… the processing script is run?

Anyway, if the code is compiling then it's not a big worry. We'll keep tweaking the dependency script, and we should have some new changes that will allow us to handle dependencies by feature inside of individual environments, the same way we now do at the global scope.

More thrilling discussions about PlatformIO advanced scripting are ongoing in the Discord, so drop by anytime.

@github-actions
Copy link

github-actions bot commented Oct 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants