Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kingroon KP3 - LCD Touchscreen does not respond to touches if printer turned on without SD card (error msg SD Init Failed) #19356

Closed
Hokeric opened this issue Sep 12, 2020 · 9 comments

Comments

@Hokeric
Copy link

Hokeric commented Sep 12, 2020

Marlin-Config Files.zip

Bug Description

My Configurations

Required: Please include a ZIP file containing your Configuration.h and Configuration_adv.h files.

Steps to Reproduce

  1. [First Step] Take out SD card from printer
  2. [Second Step] Turn on printer (without SD card)
  3. [and so on...]

Expected behavior: [What you expect to happen]
LCD touch screen will respond to touch controls
There should not be "SD init failed" error message (as in 2.0.6)

Actual behavior: [What actually happens]
LCD does not respond to touch control
LCD shows "SD init failed" when printer is turned on

Additional Information

  • Provide pictures or links to videos that clearly demonstrate the issue.
  • See How Can I Contribute for additional guidelines.
@Hokeric Hokeric changed the title [BUG] Kingroon KP3 - LCD Touchscreen freezes if printer turned on without SD card (error msg SD Init Failed) [BUG] Kingroon KP3 - LCD Touchscreen not respond to touches if printer turned on without SD card (error msg SD Init Failed) Sep 12, 2020
@Hokeric Hokeric changed the title [BUG] Kingroon KP3 - LCD Touchscreen not respond to touches if printer turned on without SD card (error msg SD Init Failed) [BUG] Kingroon KP3 - LCD Touchscreen does not respond to touches if printer turned on without SD card (error msg SD Init Failed) Sep 12, 2020
@boelle
Copy link
Contributor

boelle commented Sep 12, 2020

Please test the bugfix-2.0.x branch to see where it stands.

@Hokeric
Copy link
Author

Hokeric commented Sep 13, 2020

Have just tested the bugfix branch given. The "SD Init Failed" message was gone, and the touchscreen can be operated when the printer is turned on without SD card.

However, SD card removal and insertion are not automatically detected like in version 2.0.6. When the SD card is inserted after printer turned on without SD card, have either to do a "refresh" or "attach media" from LCD screen menu to see contents of the SD card.

Also, noticed another bug about Z homing. Z does not home if using Z probe for Z homing. When trying to home Z (either manual home Z alone, or auto home Z as an initial operation prior to bed leveling) the operation was not carried out by the printer. The LCD shows "Z probe past bed". If use Z endstop then Z can home normally.

@sjasonsmith
Copy link
Contributor

For the SD Card, try enabling NO_SD_HOST_DRIVE in Configuration_adv.h.

@Hokeric
Copy link
Author

Hokeric commented Sep 13, 2020

Tried enabling NO_SD_HOST_DRIVE in Configuration_adv.h, and there was compilation error, as follows.
FYI, SD card insertion/removal could be auto detected in release version 2.0.6 with NO_SD_HOST_DRIVE disabled.

Marlin\src\HAL\STM32F1\onboard_sd.cpp:29:23: error: 'ON_BOARD_SPI_DEVICE' was not declared in this scope
SPIClass OnBoardSPI(ON_BOARD_SPI_DEVICE);
^~~~~~~~~~~~~~~~~~Compiling .pio\build\mks_robin_mini\src\src\HAL\shared\eeprom_if_i2c.cpp.o

@sjasonsmith
Copy link
Contributor

Add this somewhere. If it fixes it, it needs to be added to the pins file. For now you can put it there, or in one of your configuration files.

#define ON_BOARD_SPI_DEVICE 1

@Hokeric
Copy link
Author

Hokeric commented Sep 14, 2020

Adding #define ON_BOARD_SPI_DEVICE 1 to the pins file fixes the SD card issue. Now the SD card insertion/removal can be detected automatically like it is in the earlier 2.0.6 release. I think this can be closed.

BTW, the Z homing issue mentioned above is no longer observed. The "Z homing bug" observed might have been due to my handling error. Please ignore that.

@Hokeric Hokeric closed this as completed Sep 15, 2020
@Hokeric
Copy link
Author

Hokeric commented Sep 15, 2020

Probably should leave it open until changes are updated in the official config files.

I did the following as advised and the SD card issue is now fixed:

  1. Enabling NO_SD_HOST_DRIVE in Configuration_adv.h
  2. Adding #define ON_BOARD_SPI_DEVICE 1 to the pins file

@Hokeric Hokeric reopened this Sep 15, 2020
@sjasonsmith sjasonsmith added the Needs: Patch A patch is needed to fix this label Sep 20, 2020
@sjasonsmith sjasonsmith removed the Needs: Patch A patch is needed to fix this label Sep 20, 2020
@Hokeric
Copy link
Author

Hokeric commented Sep 25, 2020

I am closing this case as the change has been updated in the latest bugfix release.

@Hokeric Hokeric closed this as completed Sep 25, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants