-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] #19468 breaks teensy2/AT90USB architectures #19592
Comments
Can you update PlatformIO & your libraries and see if it’s still broken? Current PIO should only output the environment you’re compiling for in the success/failed section. |
had already blown away all libs running latest PIO dev:
Configs was as per the commit with the regression. Regardless, blew all caches/libs away (again), and rebased on latest bf2 head (2e1ba73) and no change, other than the now-double-spacing on the platform report:
|
Reverting to PIO 5.0.1 from "standard" track and it behaves as yours, so another red herring:
|
There are a couple different issues impacting this build. @rhapsodyv I'm running into an issue involving library dependencies. The teensy framework has a library called Teensy_ADC, which is incompatible with this board. For some reason it is selected on Windows (in VS Code), but not in Linux! Do you know what could cause these libraries to be selected differently on different platforms? I suspect these are coming from PlatformIO, and not directly from the dependency code you worked on. Windows
Linux (actually WSL on Windows):
Both Teensy_ADC and Time are selected only on Windows... |
I just posted a pull request that allows me to build. I have not personally tested it. It would be great if you could try it out, and comment on the pull request. |
|
This platform broke again, and I fixed it again: I've added it into the CI builds so hopefully it will not be broken so easily as Marlin evolves around it. @fiveangle, can you verify whether it is working for you with the current |
@fiveangle I am also presuming this is now fixed. I’ll close the issue, but please let me know if there are still issues. |
Resolved by #19907 |
Thank you @sjasonsmith. I swear at90usb DFU seems to break every couple months and I just don't spend enough time tinkering with this old printer to keep up with the regressions. I submitted at CircleCI track to test all sample configs a few years back in order to try and stay atop these, but it was too long a compile for scott to deal with :) Nice that someone built out the CI of the project to parallelize it all to a reasonable cadence. Thanks again for all the help. BTW- another feather in the cap of everyone working on Marlin right now, I just compiled the head of BF2 for this config and it's literally the first time in about 3 years it's compiled w/o unexpected warnings (3yrs ago I went through to fix all of them, which was promptly outdated within weeks - haha). Things are looking great everyone ! 👍 -=dave |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#19468 broke teensy2 architectures:
Using Printrboard RevF configs: https://github.com/fiveangle/Marlin/tree/bisect5/Marlin
Commit 90bc199 results in architecture not detected correctly:
The text was updated successfully, but these errors were encountered: