Serial Communication has Problems because ubl.cpp is missing a newline.

[unixhelden]

After compiling and uploading todays bugfix release i noticed i had massive issues with octoprint.

After asking for help in Octoprint Forum @foosel noticed there is a problem with Marlin where it does not set the Newline for a message correctly.

diff --git a/Marlin/src/feature/bedlevel/ubl/ubl.cpp b/Marlin/src/feature/bedlevel/ubl/ubl.cpp
index 087fdf42b2..82ce79e025 100644
--- a/Marlin/src/feature/bedlevel/ubl/ubl.cpp
+++ b/Marlin/src/feature/bedlevel/ubl/ubl.cpp
@@ -43,7 +43,7 @@
#include "math.h"

void unified_bed_leveling::echo_name() {
- SERIAL_ECHOPGM("Unified Bed Leveling");
+ SERIAL_ECHOPGM("Unified Bed Leveling\n");
}

void unified_bed_leveling::report_current_mesh() {

This Patch solves the Problem.

Thx in advance :)

[ellensp]

found more details here https://community.octoprint.org/t/serial-communication-with-printer-not-reliable/27339

[ellensp]

The following seem to be in error, when DEBUG_ECHOLNPGM is disabled

           ubl.echo_name();
             DEBUG_ECHOLNPGM(" initialized.\n"); ```

[ellensp]

A better answer is find the following in Marlin/src/module/settings.cpp
//#define DEBUG_OUT 1
change to
#define DEBUG_OUT ENABLED(DEBUG_LEVELING_FEATURE)
then find

            #if ENABLED(EEPROM_CHITCHAT)
              ubl.echo_name();
              DEBUG_ECHOLNPGM(" initialized.\n");
            #endif

and change it to

            #if BOTH(EEPROM_CHITCHAT, DEBUG_LEVELING_FEATURE)
              ubl.echo_name();
              DEBUG_ECHOLNPGM(" initialized.\n");
            #endif

then find

            #if ENABLED(EEPROM_CHITCHAT)
              DEBUG_ECHOPGM("?Can't enable ");
              ubl.echo_name();

and change it to

            #if BOTH(EEPROM_CHITCHAT, DEBUG_LEVELING_FEATURE)
              DEBUG_ECHOPGM("?Can't enable ");
              ubl.echo_name();

[ellensp]

PR created

[ellensp]

This has now been merged so is in bugfix.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.