Skip to content

[BUG] Compilation error when MESH_EDIT_MENU is enabled for AUTO_BED_LEVELING_[LINEAR|3POINT] #21908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ondrada opened this issue May 14, 2021 · 3 comments

Comments

@ondrada
Copy link
Contributor

ondrada commented May 14, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

When ABL is configured as AUTO_BED_LEVELING_LINEAR or AUTO_BED_LEVELING_3POINT and both LCD_BED_LEVELING and MESH_EDIT_MENU options are enabled in Configuration.h, Marlin fails to compile and gives errors about undeclared preprocessor variables Z_VALUES (for both AUTO_BED_LEVELING_3POINT and AUTO_BED_LEVELING_LINEAR) and GRID_MAX_POINTS_X and GRID_MAX_POINTS_Y (for AUTO_BED_LEVELING_3POINT only).

I've tried to solve that by adding a condition to enable Mesh edit menu only if HAS_MESH (here: ondrada@63150c5 ). But don't know if it wouldn't be better to add a conditional like "MESH_EDIT_MENU is not compatible with AUTO_BED_LEVELING_LINEAR/AUTO_BED_LEVELING_3POINT", or if it is possible to have the menu without 'Z' part for AUTO_BED_LEVELING_LINEAR.

Bug Timeline

No response

Expected behavior

Compilable Marlin when AUTO_BED_LEVELING_[LINEAR|3POINT] is selected together with LCD_BED_LEVELING and MESH_EDIT_MENU, or some incompatibility message.

Actual behavior

Compilation failure with beyond combination of options in Configuration.h

Steps to Reproduce

Try to compile Marlin with:
LCD_BED_LEVELING enabled
MESH_EDIT_MENU enabled
AUTO_BED_LEVELING_LINEAR or AUTO_BED_LEVELING_3POINT enabled

Version of Marlin Firmware

2.0.x bugfix

Printer model

Ender 3 Pro

Electronics

BTT E3 RRF

Add-ons

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

@ellensp
Copy link
Contributor

ellensp commented May 15, 2021

AUTO_BED_LEVELING_LINEAR and AUTO_BED_LEVELING_3POINT are not MESHES, so enabling MESH_EDIT_MENU does not make sense.

@ellensp ellensp closed this as completed May 15, 2021
@ondrada
Copy link
Contributor Author

ondrada commented May 15, 2021

I see that, wasn't sure about LINEAR... But shouldn't there be some message like "MESH_EDIT_MENU is not compatible with AUTO_BED_LEVELING_LINEAR/AUTO_BED_LEVELING_3POINT" in SanityCheck.h or somewhere, rather than compile errors at Marlin/src/lcd/menu/menu_bed_leveling.cpp ?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants