[BUG] (cannot compile when using Y_MAX Endstop with dual steppers SKR1_4) #22484
Comments
|
Take a look at the board, at the labels, do you see any X Max or Y Max endstop plugs? No you don't. because this board only has x_stop, y_stop, z_stop, e0_det and e1_det. If you wan't to use e0_det and e1_det you have to tell marlin to do so. Ie In Configuration_adv.h you need #define X_DUAL_STEPPER_DRIVERS
#if ENABLED(X_DUAL_STEPPER_DRIVERS)
#define INVERT_X2_VS_X_DIR // Enable if X2 direction signal is opposite to X
#define X_DUAL_ENDSTOPS
#if ENABLED(X_DUAL_ENDSTOPS)
#define X2_USE_ENDSTOP _E0DIAG_
#define X2_ENDSTOP_ADJUSTMENT 0
#endif
#endif
#define Y_DUAL_STEPPER_DRIVERS
#if ENABLED(Y_DUAL_STEPPER_DRIVERS)
#define INVERT_Y2_VS_Y_DIR // Enable if Y2 direction signal is opposite to Y
#define Y_DUAL_ENDSTOPS
#if ENABLED(Y_DUAL_ENDSTOPS)
#define Y2_USE_ENDSTOP _E1DIAG_
#define Y2_ENDSTOP_ADJUSTMENT 0
#endif
#endif
|
|
Thank you for your help! I would like to add, that I was confused by the pins.h file for the SKR board. Based on it I thought I didn't have to change the Endstop even though I considered it as a cause of the problem. I wrote it off due to the following: //
// TMC StallGuard DIAG pins
//
#define X_DIAG_PIN P1_29 // X-STOP
#define Y_DIAG_PIN P1_28 // Y-STOP
#define Z_DIAG_PIN P1_27 // Z-STOP
#define E0_DIAG_PIN P1_26 // E0DET
#define E1_DIAG_PIN P1_25 // E1DETAs I neither have extruders nor TMC StallGuard, I assumed P1_26 and P1_25 were not assigned. //
// Limit Switches
//
#ifdef X_STALL_SENSITIVITY
#define X_STOP_PIN X_DIAG_PIN
#if X_HOME_TO_MIN
#define X_MAX_PIN P1_26 // E0DET
#else
#define X_MIN_PIN P1_26 // E0DET
#endif
#elif ENABLED(X_DUAL_ENDSTOPS)
#ifndef X_MIN_PIN
#define X_MIN_PIN P1_29 // X-STOP
#endif
#ifndef X_MAX_PIN
#define X_MAX_PIN P1_26 // E0DET
#endif
#else
#define X_STOP_PIN P1_29 // X-STOP
#endif
#ifdef Y_STALL_SENSITIVITY
#define Y_STOP_PIN Y_DIAG_PIN
#if Y_HOME_TO_MIN
#define Y_MAX_PIN P1_25 // E1DET
#else
#define Y_MIN_PIN P1_25 // E1DET
#endif
#elif ENABLED(Y_DUAL_ENDSTOPS)
#ifndef Y_MIN_PIN
#define Y_MIN_PIN P1_28 // Y-STOP
#endif
#ifndef Y_MAX_PIN
#define Y_MAX_PIN P1_25 // E1DET
#endif
#else
#define Y_STOP_PIN P1_28 // Y-STOP
#endifI assumed they would have been assigned as the X_MAX and Y_MAX pins due to the Maybe this needs some clarification or this is a feature not yet completely implemented and will be in the future? |
|
reopening for further research |
|
I think that is someones attempt at avoiding having to set E0DIAG and E1DIAG What I have found so far is there is a macro The test |
|
That construct in some pins files that have DIAG pins was requested so that an unused endstop pin would have a pin name (the unused endstop at the other end of the axis). The curious can use "Line History" to find out more about those changes and take a look at the original conversations. Meanwhile, we should mitigate any side-effects from that. |
|
@thinkyhead yes that was before someone added #elif ENABLED(Y_DUAL_ENDSTOPS) code to the pins file |
|
issue stems from #define Y_HOME_DIR 1 with Y_DUAL_ENDSTOPS In endstops.h so if homing to max, it presumes Y_MAX exists, but Y_MAX does not exists when Y_DUAL_ENDSTOPS is enable |
|
That |
|
Checking on the rest of the code, |
|
So, this might work in #if ALL(HAS_Y_AXIS, Y_HOME_TO_MIN, USE_YMIN_PLUG) && _HAS_STOP(Y,MIN)
#define HAS_Y_MIN 1
#endif
#if ALL(HAS_Y_AXIS, Y_HOME_TO_MAX, USE_YMAX_PLUG) && _HAS_STOP(Y,MAX)
#define HAS_Y_MAX 1
#endif
#if ALL(HAS_Z_AXIS, Z_HOME_TO_MIN, USE_ZMIN_PLUG) && _HAS_STOP(Z,MIN)
#define HAS_Z_MIN 1
#endif
#if ALL(HAS_Z_AXIS, Z_HOME_TO_MAX, USE_ZMAX_PLUG) && _HAS_STOP(Z,MAX)
#define HAS_Z_MAX 1
#endif
#if LINEAR_AXES >= 4 && ENABLED(USE_IMIN_PLUG) && _HAS_STOP(I,MIN)
#define HAS_I_MIN 1
#endif
#if LINEAR_AXES >= 4 && ENABLED(USE_IMAX_PLUG) && _HAS_STOP(I,MAX)
#define HAS_I_MAX 1
#endif
#if LINEAR_AXES >= 5 && ENABLED(USE_JMIN_PLUG) && _HAS_STOP(J,MIN)
#define HAS_J_MIN 1
#endif
#if LINEAR_AXES >= 5 && ENABLED(USE_JMAX_PLUG) && _HAS_STOP(J,MAX)
#define HAS_J_MAX 1
#endif
#if LINEAR_AXES >= 6 && ENABLED(USE_KMIN_PLUG) && _HAS_STOP(K,MIN)
#define HAS_K_MIN 1
#endif
#if LINEAR_AXES >= 6 && ENABLED(USE_KMAX_PLUG) && _HAS_STOP(K,MAX)
#define HAS_K_MAX 1
#endif
#if ENABLED(X_DUAL_ENDSTOPS) && PIN_EXISTS(X2_MIN)
#define HAS_X2_MIN 1
#endif
#if ENABLED(X_DUAL_ENDSTOPS) && PIN_EXISTS(X2_MAX)
#define HAS_X2_MAX 1
#endif
#if ENABLED(Y_DUAL_ENDSTOPS) && PIN_EXISTS(Y2_MIN)
#define HAS_Y2_MIN 1
#endif
#if ENABLED(Y_DUAL_ENDSTOPS) && PIN_EXISTS(Y2_MAX)
#define HAS_Y2_MAX 1
#endif
#if ENABLED(Z_MULTI_ENDSTOPS)
#if PIN_EXISTS(Z2_MIN)
#define HAS_Z2_MIN 1
#endif
#if PIN_EXISTS(Z2_MAX)
#define HAS_Z2_MAX 1
#endif
#if NUM_Z_STEPPER_DRIVERS >= 3
#if PIN_EXISTS(Z3_MIN)
#define HAS_Z3_MIN 1
#endif
#if PIN_EXISTS(Z3_MAX)
#define HAS_Z3_MAX 1
#endif
#endif
#if NUM_Z_STEPPER_DRIVERS >= 4
#if PIN_EXISTS(Z4_MIN)
#define HAS_Z4_MIN 1
#endif
#if PIN_EXISTS(Z4_MAX)
#define HAS_Z4_MAX 1
#endif
#endif
#endif |
|
Then in // Extra Endstops for XYZ
_ES_ITEM(HAS_X2_MIN, X2_MIN)
_ES_ITEM(HAS_X2_MAX, X2_MAX)
_ES_ITEM(HAS_Y2_MIN, Y2_MIN)
_ES_ITEM(HAS_Y2_MAX, Y2_MAX)
_ES_ITEM(HAS_Z2_MIN, Z2_MIN)
_ES_ITEM(HAS_Z2_MAX, Z2_MAX)
_ES_ITEM(HAS_Z3_MIN, Z3_MIN)
_ES_ITEM(HAS_Z3_MAX, Z3_MAX)
_ES_ITEM(HAS_Z4_MIN, Z4_MIN)
_ES_ITEM(HAS_Z4_MAX, Z4_MAX) |
|
As far as I can tell, there is no implementation of |
|
I pushed a patch for endstop flags and it could use some extra confirmation. Please test the |
|
Hi |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.0.xcode?Yes, and the problem still exists.
Bug Description
I'm trying to compile my custom firmware for the MPCNC.
I had the same issue with 2.0.8, then upgraded to 2.0.9 to see if it was fixed.
I have no extruders but want to have dual x and -y steppers. Also, I have the necessary endstop switches to have an endstop for the second steppers. Adding the items one by one showed, that enabeling
#define Y_DUAL_ENDSTOPSis the culprit.So far I've tried:
#define X_DUAL_STEPPER_DRIVERS-> Build Failed#define X_DUAL_ENDSTOPS-> Build FailedI also tried to modify the pins.h file.
According to a recommendation on the Marlin Discord in support, I added the following lines:
#define Y_MAX P1_25leading toMarlin\src\module\stepper.cpp:369:55: error: 'Y2_MAX' was not declared in this scope; did you mean 'Y_MAX'? ...#define Y2_MAX P1_25leading toMarlin\src\module/endstops.h:82:39: error: 'Y_MAX' was not declared in this scope; did you mean 'Y2_MAX'?leading to:
Bug Timeline
2.0.8
Expected behavior
Compile.
Actual behavior
Created an error:
Steps to Reproduce
Version of Marlin Firmware
Bugfix 2.0.9
Printer model
MPCNC
Electronics
BTT_SKR_V1_4, TMC2208
Add-ons
No response
Your Slicer
No response
Host Software
No response
Additional information & file uploads
def Y_DUAL_ENDSTOPS.txt
ndef Y_DUAL_ENDSTOPS.txt
configuration.zip
The text was updated successfully, but these errors were encountered: