Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (UI: "Heating" label is shown during the cooldown state) #23441

Closed
Dentrax opened this issue Jan 3, 2022 · 12 comments
Closed

[BUG] (UI: "Heating" label is shown during the cooldown state) #23441

Dentrax opened this issue Jan 3, 2022 · 12 comments

Comments

@Dentrax
Copy link

Dentrax commented Jan 3, 2022

Did you test the latest bugfix-2.0.x code?

No, but I will test it now!

Bug Description

I am not sure which condition triggered this UI bug but, the label indicates "E1 Heating" during the cooling down state. Pressing the "Cooldown" button does not affect either the UI or status.

I just upgraded my Marlin from v1.0.1 to latest.

P.S: I used the corresponding configs: https://github.com/MarlinFirmware/Configurations/tree/2.0.9.3/config/examples/Creality/Ender-3%20V2

Bug Timeline

No response

Expected behavior

"Heating" label should be hidden during the cooling down state.

Actual behavior

"Heating" label is shown during the cooling down state.

Steps to Reproduce

  1. Stop the printing?

Version of Marlin Firmware

2.0.9.3

Printer model

Creality Ender 3 V2

Electronics

Stock

Add-ons

No response

Bed Leveling

No Bed Leveling

Your Slicer

Cura

Host Software

SD Card (headless)

Additional information & file uploads

VID_20220103_230046.mp4
@Dentrax Dentrax changed the title [BUG] (UI: "Heating" label does not update during the cleaning state) [BUG] (UI: "Heating" label does not update during the cooldown state) Jan 3, 2022
@Dentrax Dentrax changed the title [BUG] (UI: "Heating" label does not update during the cooldown state) [BUG] (UI: "Heating" label is shown during the cooldown state) Jan 3, 2022
@thinkyhead
Copy link
Member

It may simply be leaving the old message up. The only thing the "Cooldown" option in that UI does is call thermalManager.cooldown() and nothing else.

@Dentrax
Copy link
Author

Dentrax commented Jan 5, 2022

So you mean thermalManager.cooldown() does not interact with UI under the hood?

@thinkyhead
Copy link
Member

static void cooldown() {
  zero_fan_speeds();
  disable_all_heaters();
}

@Dentrax
Copy link
Author

Dentrax commented Jan 5, 2022

Hmm, should we add a function something like refresh_status_ui()? (But this one will not solve the issue I think, right?) Would you like any help with this issue? Not making any promises but I'd be interested in looking into it. 🙏

@thinkyhead
Copy link
Member

The method ui.reset_status() resets the status message to the default for the current machine state. It should be used by UI implementations when appropriate. It is the direct method to do this, so it doesn't check whether there is an "important" message on the screen which should not be cleared.

@thinkyhead
Copy link
Member

e.g., For dwin.cpp line 2762…

      #if HAS_HOTEND || HAS_HEATED_BED
        case PREPARE_CASE_COOL:
          thermalManager.cooldown();
          ui.reset_status();
          break;
      #endif

@Sonicboom247
Copy link

e.g., For dwin.cpp line 2762…

      #if HAS_HOTEND || HAS_HEATED_BED
        case PREPARE_CASE_COOL:
          thermalManager.cooldown();
          ui.reset_status();
          break;
      #endif

Question, will this be merged soon? Now seeing similar issue on an Ender 3 V2 and Artillery Hornet. Except both read Bed Cooling the entire time they are printing.

@thisiskeithb
Copy link
Member

thisiskeithb commented Jan 10, 2022

Question, will this be merged soon? Now seeing similar issue on an Ender 3 V2 and Artillery Hornet. Except both read Bed Cooling the entire time they are printing.

There's also the bed heating/cooling status reset bug that may be affecting this: #23135

@Sonicboom247
Copy link

Sonicboom247 commented Jan 13, 2022

Question, will this be merged soon? Now seeing similar issue on an Ender 3 V2 and Artillery Hornet. Except both read Bed Cooling the entire time they are printing.

There's also the bed heating/cooling status reset bug that may be affecting this: #23135

edit: seems like the ender 3 is still not behaving as it should even with LCD_TIMEOUT_TO_STATUS commented out, it seemed ok until the gcode dropped the bed temp from 60 to 58 as instructed, but it did not switch back to file name.

@Sonicboom247
Copy link

Don't even recall which printer i was working on last night but one or two of them received an update and now.
20220113_171847
And after bed dropped two degrees it went back to time left.
20220113_170451

Even though time left and remaining are quite off, it syncs then goes off a bit.

@thisiskeithb
Copy link
Member

#23135 has been merged and there's a new option STATUS_MESSAGE_TIMEOUT_SEC to timeout low-priority status messages.

Please download bugfix-2.0.x to test with the latest code and let us know if you're still having this issue.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants