Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Gcode reporting format M503 is a mess #24241

Closed
rondlh opened this issue May 25, 2022 · 3 comments
Closed

[BUG] Gcode reporting format M503 is a mess #24241

rondlh opened this issue May 25, 2022 · 3 comments

Comments

@rondlh
Copy link
Contributor

rondlh commented May 25, 2022

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

The gcode reporting output format M503, like for example the output of GcodeSuite::M906_report is a mess:

echo: M906X:900Y:900Z:900

I think this is because of the macro in serial.cpp, line 38

#define _SP_N_STR(N) PGMSTR(SP_##N##_STR, STR_##N ":");

which should be:

#define _SP_N_STR(N) PGMSTR(SP_##N##_STR, " " STR_##N);

this will correct the output to:

echo: M906 X900 Y900 Z900

I'm not sure if it causes other side effects.

Bug Timeline

Don't know

Expected behavior

Proper gcode reporting output

echo: M906 X900 Y900 Z900

Actual behavior

Incorrect reporting output:

echo: M906X:900Y:900Z:900

Steps to Reproduce

Check the output of M503

Version of Marlin Firmware

Marlin 2.0.9.3 latest bugfix

Printer model

Custom

Electronics

Custom

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Additional information & file uploads

No response

@radek8
Copy link
Contributor

radek8 commented May 29, 2022

fixed in
#24259

@rondlh
Copy link
Contributor Author

rondlh commented May 31, 2022

Great job, thanks!

@rondlh rondlh closed this as completed May 31, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants