Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X_AXIS_TWIST_COMPENSATION causes Warning to be generated when compiling Marlin 2.1 #24357

Closed
1 task done
CBoismenu opened this issue Jun 16, 2022 · 5 comments
Closed
1 task done

Comments

@CBoismenu
Copy link

CBoismenu commented Jun 16, 2022

Did you test the latest bugfix-2.1.x code?

Yes, same warning is generated.

Bug Description

I have been working on compiling a version of Marlin 2.1 and was able to do so without getting any errors or warning.

The problem starts if i try to enable X_AXIX_TWIST_COMPENSATION.

When i try to compile the firmware I get the following warning:

Marlin\src\lcd\menu\menu_x_twist.cpp: In function 'void xatc_wizard_menu()':
Marlin\src\lcd\menu\menu_x_twist.cpp:104:19: warning: unused variable 'digs' [-Wunused-variable]
104 | const uint8_t digs = !UNEAR_ZERO((FINE_MANUAL_MOVE) * 1000 - int((FINE_MANUAL_MOVE) * 1000)) ? 4 :
| ^~~~

Has anybody seen that and if so is it normal, if not would anyone have any idea on how to remedy the situation.

Thanks,

Bug Timeline

new

Expected behavior

Expected no warning to be generated when compi;ing the firmware

Actual behavior

See generated warning message when compiling the firmware.

Steps to Reproduce

No response

Version of Marlin Firmware

2.1

Printer model

Prusa bear clone with bltouch

Electronics

SKR2

Add-ons

No response

Bed Leveling

ABL Bilinear mesh

Your Slicer

No response

Host Software

No response

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin.zip

@thisiskeithb
Copy link
Member

The usage of digs was removed in #24278, but the warning can be safely ignored.

@CBoismenu
Copy link
Author

I also modified the pins_BTT_SKR_V2_0_common.h file to add an I2C EEPROM to the board fili is attache
pins_BTT_SKR_V2_0_common.zip
d

@CBoismenu
Copy link
Author

Thank you for the quick reply. Will try the compiled version on my printer and see how it goes.

@thisiskeithb
Copy link
Member

thisiskeithb commented Jun 16, 2022

I've submitted #24358 to remove the unused digs variable.

See #24328

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants