Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] src/core/types.h (assignment of read-only location 'v') #24864

Closed
1 task done
murrayhenwood opened this issue Oct 12, 2022 · 7 comments
Closed
1 task done

[BUG] src/core/types.h (assignment of read-only location 'v') #24864

murrayhenwood opened this issue Oct 12, 2022 · 7 comments

Comments

@murrayhenwood
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

In src/core/types.h source file line 598, 599, 752 the code tries to assign to operation parameter.

the lines in question
598
FI XYZval& operator*=(const float &v) { NUM_AXIS_CODE(x *= v, y *= v, z *= v, i *= v, j *= v, k *= v, u *= v, v *= v, w *= v); return this; }
599
FI XYZval& operator
=(const int &v) { NUM_AXIS_CODE(x *= v, y *= v, z *= v, i *= v, j *= v, k *= v, u *= v, v *= v, w *= v); return this; }
752
FI XYZEval& operator
=(const T &v) { LOGICAL_AXIS_CODE(e *= v, x *= v, y *= v, z *= v, i *= v, j *= v, k *= v, u *= v, v *= v, w *= v); return *this; }

Bug Timeline

not sure

Expected behavior

Code to compile

Actual behavior

No response

Steps to Reproduce

  1. Try to compile with 8 axis

Version of Marlin Firmware

2.1.X

Printer model

No response

Electronics

No response

Add-ons

No response

Bed Leveling

No response

Your Slicer

No response

Host Software

No response

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No configuration needed after reading the code it should be clear about the problem

@ellensp
Copy link
Contributor

ellensp commented Oct 12, 2022

How about those configs so we don't have to waste time recreating this?

yes v *= v is obvious, but so is

Don't forget to include
A ZIP file containing your Configuration.h and Configuration_adv.h.

@murrayhenwood
Copy link
Author

Sorry, There are no boards have the pin definitions needed to show the problem and therefor there is no simple configuration and changes that could be zipped up.
This is obviously a niche problem, feel free to close the issue.

@EvilGremlin
Copy link
Contributor

Then link to your fork or something. If fixing this could save us feature headaches it's worth looking at. Making Marlin more flexible and scalabe (both up and down) is ever-present goal.

@ellensp
Copy link
Contributor

ellensp commented Oct 12, 2022

I working on a eg configs for an octopus, 8 axis, 0 extrudes. will be done shortly..

@murrayhenwood
Copy link
Author

Roughly I think these are the minimum changes needed, using Platform IO for the build
https://github.com/murrayhenwood/Marlin

@ellensp
Copy link
Contributor

ellensp commented Oct 12, 2022

PR #24866 should fix it

@ellensp ellensp closed this as completed Oct 12, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants