Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Status Message cleanup commit compilation error #25692

Closed
1 task done
ThomasToka opened this issue Apr 16, 2023 · 6 comments
Closed
1 task done

[BUG] Status Message cleanup commit compilation error #25692

ThomasToka opened this issue Apr 16, 2023 · 6 comments

Comments

@ThomasToka
Copy link
Contributor

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

After applying this commit 9a1c025 compilation of my fork stopped.

Probaly due to the usage of the Creality lcd_rts.cpp in the config. Before this commit it compiled fine.

Error Message in actual behavior.

Bug Timeline

New bug after applying upstream commits

Expected behavior

Compilation works

Actual behavior

Marlin\src\gcode\bedlevel\G26.cpp: In member function 'bool::turn_on_heaters()':
Marlin\src\gcode\bedlevel\G26.cpp:325:12: error: 'class MarlinUI' has no member named 'quick_feedback'
325 | ui.quick_feedback();
| ^~~~~~~~~~~~~~
Marlin\src\gcode\bedlevel\G26.cpp:342:8: error: 'class MarlinUI' has no member named 'quick_feedback'
342 | ui.quick_feedback();
| ^~~~~~~~~~~~~~
Marlin\src\gcode\bedlevel\G26.cpp:350:8: error: 'class MarlinUI' has no member named 'completion_feedback'
350 | ui.completion_feedback();
| ^~~~~~~~~~~~~~~~~~~
Marlin\src\gcode\bedlevel\G26.cpp: In member function 'bool::prime_nozzle()':
Marlin\src\gcode\bedlevel\G26.cpp:403:10: error: 'class MarlinUI' has no member named 'quick_feedback'
403 | ui.quick_feedback();

Steps to Reproduce

  • apply commit with lcd_rts.cpp enabled

Version of Marlin Firmware

bugfix-2.1.x

Printer model

Ender 3 S1 Pro

Electronics

Creality F4 Mainboard

Add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

configurations.zip

@thisiskeithb
Copy link
Member

apply commit with lcd_rts.cpp enabled

Is this custom code/from some other fork? We don’t have this file.

@ThomasToka
Copy link
Contributor Author

yeah sure. i am porting crealitys ender 3 s1 pro code. pr for this will be made on the 9th of may.

https://github.com/CrealityOfficial/Ender-3S1/blob/s1_pro/Marlin/src/lcd/dwin/lcd_rts.cpp

@thisiskeithb
Copy link
Member

I wouldn't consider this a Marlin bug since that code doesn't exist here. You'll need to fix it in your fork, but here are some places to look for help:

@ThomasToka
Copy link
Contributor Author

Ok i understand. no problem. thought it would affect other implementations also.

Will close this then and build a workaround for my fork.

@ellensp
Copy link
Contributor

ellensp commented Apr 21, 2023

Because this issue mentioned Creality lcd_rts.cpp and pointed to a non official marlin fork, this was miss diagnosed as an issue with that fork only.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants