Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Errors if MMU2 Menus are enabled #25824

Closed
1 task done
hounslg opened this issue May 13, 2023 · 3 comments · Fixed by #25825
Closed
1 task done

Compilation Errors if MMU2 Menus are enabled #25824

hounslg opened this issue May 13, 2023 · 3 comments · Fixed by #25825

Comments

@hounslg
Copy link

hounslg commented May 13, 2023

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Since the commit Improve MMU2 unload (like original MMU2S) if you enable the MMU2_MENUS the compile fails with an error -

Marlin\src\lcd\menu\menu_mmu2.cpp: In function 'void action_mmu2_load_all()':
Marlin\src\lcd\menu\menu_mmu2.cpp:50:19: error: '_mmu2_load_filament' was not declared in this scope; did you mean 'unload_filament'?

Disabling this setting, or reverting the commit allows you to compile.

Bug Timeline

New bug since last week

Expected behavior

The compile to succeed.

Actual behavior

Compile fails

Steps to Reproduce

  1. Using latest head of Bugfix-2.1.x
  2. Enable MMU2 in config.h, ensuring serial ports don't clash
  3. Compile to validate set-up
  4. Uncomment #define MMU2_MENUS
  5. Compile - this will error
  6. Revert the commit Improve MMU2 unload (like original MMU2S
  7. Compile - this will succeed

Version of Marlin Firmware

Bugfix-2.1.x

Printer model

Modified Ender 3 with MMU2

Electronics

BigTreeTech SKR Mini E3 2.0, MMU2 unit running latest Prusa firmware

Add-ons

MMU2

Bed Leveling

No Bed Leveling

Your Slicer

Prusa Slicer

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Marlin.zip

I took the latest Ender 3 Bigtree Tech SKR Mini E2 config files from the Bugfix-2.1.x branch and made changes just to test the MMU2 config, just in case it was something odd in my original config files. These 'vanilla' config files had the same behaviour as my customised ones.

Compiling using Visual Studio and Auto Build Marlin on Windows 11

@hounslg
Copy link
Author

hounslg commented May 13, 2023

Also meant to say I took a fresh copy of the bugfix-2.1.x branch and tested with this and had the same issue.

@GMagician
Copy link
Contributor

GMagician commented May 13, 2023

rename _mmu2_load_filament to _mmu2_load_to_feeder

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants