Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] (DEBUG_ECHOF not defined) #26493

Closed
1 task done
narno2202 opened this issue Dec 2, 2023 · 5 comments · Fixed by #26495
Closed
1 task done

[BUG] (DEBUG_ECHOF not defined) #26493

narno2202 opened this issue Dec 2, 2023 · 5 comments · Fixed by #26495

Comments

@narno2202
Copy link
Contributor

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When I enable DEBUG_LEVELING_FEATURE to investigate BLTouch HS_Mode in FT_MOTION, Marlin can't compile sending DEBUG_ECHOF not defined, replacing the faulty macro by DEBUG_ECHO, compile and debug went fine.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

latest bugfix

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

ABL Bilinear mesh

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@classicrocker883
Copy link
Contributor

do you know how to do a Pull Request? you should do that, you'll be able to be credited for this fix.

@thisiskeithb
Copy link
Member

do you know how to do a Pull Request? you should do that, you'll be able to be credited for this fix.

image

@thisiskeithb
Copy link
Member

thisiskeithb commented Dec 3, 2023

DEBUG_ECHOF() was removed in #25928 and replaced with DEBUG_ECHOLN(prefix, F() in most places.

Based on changes in that PR, this should be the fix:

diff --git a/Marlin/src/gcode/calibrate/G28.cpp b/Marlin/src/gcode/calibrate/G28.cpp
index ba16c7b..dbdbdc5 100644
--- a/Marlin/src/gcode/calibrate/G28.cpp
+++ b/Marlin/src/gcode/calibrate/G28.cpp
@@ -263,7 +263,7 @@ void GcodeSuite::G28() {
 
       #if ENABLED(DEBUG_LEVELING_FEATURE)
         auto debug_current = [](FSTR_P const s, const int16_t a, const int16_t b) {
-          if (DEBUGGING(LEVELING)) { DEBUG_ECHOF(s); DEBUG_ECHOLNPGM(" current: ", a, " -> ", b); }
+          if (DEBUGGING(LEVELING)) { DEBUG_ECHOLN(s, F(" current: "), a, F(" -> "), b); }
         };
       #else
         #define debug_current(...)
diff --git a/Marlin/src/module/endstops.cpp b/Marlin/src/module/endstops.cpp
index 0f060f5..9c6a3c0 100644
--- a/Marlin/src/module/endstops.cpp
+++ b/Marlin/src/module/endstops.cpp
@@ -1360,7 +1360,7 @@ void Endstops::update() {
 
       #if ENABLED(DEBUG_LEVELING_FEATURE)
         auto debug_current = [](FSTR_P const s, const int16_t a, const int16_t b) {
-          if (DEBUGGING(LEVELING)) { DEBUG_ECHOF(s); DEBUG_ECHOLNPGM(" current: ", a, " -> ", b); }
+          if (DEBUGGING(LEVELING)) { DEBUG_ECHOLN(s, F(" current: "), a, F(" -> "), b); }
         };
       #else
         #define debug_current(...)

@thisiskeithb
Copy link
Member

Thanks for the report!

Fixed in #26495

Copy link

github-actions bot commented Feb 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants