Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Inversed Markforged / Hybrid Corexy #26515

Closed
jesterhead82 opened this issue Dec 8, 2023 · 3 comments · Fixed by #26516
Closed

[FR] Inversed Markforged / Hybrid Corexy #26515

jesterhead82 opened this issue Dec 8, 2023 · 3 comments · Fixed by #26516
Labels
K: Core / H-Bot T: Feature Request Features requested by users.

Comments

@jesterhead82
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently Marlin supports only Markforged / Belt paths as defined in #23163
Klipper e.g. has the same issue. the implemention of a inversed belt (e.g. Ratrig Idex) is not in mainline yet.

As a workaround I changed the maths (replace + with - and vice versa) to support my printer (its not finished yet, but at least axis are moving now correctly).
I Changed only the maths for the XY type, but I guess the same could be usefull for YX layouts.

In theory, if somebody tells me how would such a feature would be properly named / configured I could try to assemble a PR...

Planner.cpp:
~line 1992

#elif ENABLED(MARKFORGED_XY)
dm.a = (dist.a - dist.b > 0); // Motor A direction
dm.b = (dist.b > 0);

~line 2065
ABS(dist.a - dist.b), ABS(dist.b), ABS(dist.c)

~line 2113
dist_mm.a = (dist.a + dist.b) * mm_per_step[A_AXIS];

Stepper.cpp
~Line 3290

count_position.set(spos.a + spos.b, spos.b, spos.c);

~ 3383
#elif ENABLED(MARKFORGED_XY)
axis == CORE_AXIS_1
? count_position[CORE_AXIS_1] + count_position[CORE_AXIS_2]
: count_position[CORE_AXIS_2]

Are you looking for hardware support?

Custom Markforged kinematics

Describe the feature you want

Possibility to configure inverse markeforged (different beltpath)

Additional context

No response

@jesterhead82 jesterhead82 added the T: Feature Request Features requested by users. label Dec 8, 2023
@EvilGremlin
Copy link
Contributor

MARKFORGED_XY & MARKFORGED_YX looks ok

@thisiskeithb
Copy link
Member

Closing since you've opened a PR.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
K: Core / H-Bot T: Feature Request Features requested by users.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants