Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typo in esp3dlibconfig.h - MARLIN_PATH #26622

Closed
1 task done
sargonphin opened this issue Jan 4, 2024 · 8 comments
Closed
1 task done

[BUG] Typo in esp3dlibconfig.h - MARLIN_PATH #26622

sargonphin opened this issue Jan 4, 2024 · 8 comments

Comments

@sargonphin
Copy link
Contributor

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

There is a typo in the relative path at line 45 of the file esp3dlibconfig.h:

#include MARLIN_PATH(inc/MarlinConfigPre.h)

This returns a file not found error:

.pio\libdeps\STM32H723ZE_btt\ESP3DLib\src\esp3dlibconfig.h:45:54: fatal error: C:/Users/x/OneDrive/3D/inc/MarlinConfigPre.h: No such file or directory

After correcting the line I now get this and I am stuck there:

#include MARLIN_PATH(Marlin/src/inc/MarlinConfigPre.h)

.pio\libdeps\STM32H723ZE_btt\ESP3DLib\src\esp3dlibconfig.h:45:54: fatal error: C:/Users/x/OneDrive/3D/Marlin/src/inc/MarlinConfigPre.h: No such file or directory

The folder "3D" is supposed to be "3D PRINTING". It was my mistake though, I usually never put spaces in folder names for that exact reason. But I don't know how to fix that. No, renaming the folder is ABSOLUTELY NOT an option! XD This would break a considerable amount of already-configured paths for many other projects

Also as you can see I am using a BTT Octopus MAX EZ with the STM32H723ZE MCU. I am currently trying to configure the Wifi add-on board ESP32U-WROOM that I bought ages ago

Bug Timeline

N/A

Expected behavior

N/A

Actual behavior

N/A

Steps to Reproduce

N/A

Version of Marlin Firmware

Latest available at the time of writing

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

I cannot include the configuration ZIP's for now, I will do that later if I can

@thisiskeithb
Copy link
Member

BTT Octopus MAX EZ with the STM32H723ZE MCU. I am currently trying to configure the Wifi add-on board ESP32U-WROOM that I bought ages ago

This board is not an ESP32-based board. You simply enable the correct serial port for the WiFi addon module and not WIFISUPPORT/ ESP3D_WIFISUPPORT.

@sargonphin
Copy link
Contributor Author

So what's the deal with this adapter here:

https://www.amazon.de/-/en/gp/product/B0B5ZWT3JP

It's supposed to be compatible with the board I have. Is it just not supported by Marlin at all? I can see its Wifi hotspot when I slot it into the board and such but no way to use it with Marlin so far

@ellensp
Copy link
Contributor

ellensp commented Jan 4, 2024

This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

After seeking help from the community, if the consensus points to a bug in Marlin, then you should post a bug report.

@sargonphin
Copy link
Contributor Author

I think something was not clear from the begining. My board has Wifi support as an add-in card, and has the following section in its pins, from file Marlin\src\pins\stm32h7\pins_BTT_OCTOPUS_MAX_EZ.h:

image

But it requires WIFISUPPORT to be enabled. This is where I am confused regarding the Wifi add-in card, because if I enable this, it complains about the initial problem I have encountered earlier.

So should this section in the pins file be removed? Or is something different expected in this port?

@EvilGremlin
Copy link
Contributor

These pins are not used. There was intention to untie WIFISUPPORT from platform and apply it to modules too (for potential GPIO functions) but changes weren't completed.

@thisiskeithb
Copy link
Member

thisiskeithb commented Jan 4, 2024

Those ESP wifi addons need to be flashed using a programmer like the BTT Writer with firmware like ESP3D. Then you enable the proper serial port in Marlin and that's it. They communicate over serial.

While some non-ESP32 boards have WIFISUPPORT code blocks in them, they do not apply here.

@sargonphin
Copy link
Contributor Author

Okay super thanks! :) this is helpful

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants