Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DGUS_LCD_UI_RELOADED not compiling Marlin 2.1.2.2 #26859

Closed
1 task done
Ale11Re opened this issue Mar 10, 2024 · 6 comments
Closed
1 task done

[BUG] DGUS_LCD_UI_RELOADED not compiling Marlin 2.1.2.2 #26859

Ale11Re opened this issue Mar 10, 2024 · 6 comments
Labels
Bug: Confirmed ! Fix Included A fix is included in the description

Comments

@Ale11Re
Copy link

Ale11Re commented Mar 10, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When selecting DGUS_LCD_UI_RELOADED to compile with CR10s Pro. I'm providing my configurations. It does compile with Marlin 2.1.2.1. I did also try with latest Marlin bugfix 2.1.x but does not compile due to other errors. Compilation error: ExtUI not defined. When commenting line 111 of /src/feature/powerloss.cpp "TERN_(EXTENSIBLE_UI, ExtUI::onSetPowerLoss(enabled));" It compiles fine.
Screenshot 2024-03-10 200256

Bug Timeline

No response

Expected behavior

Expect Marlin 2.1.2.2 to compile

Actual behavior

Marlin 2.1.2.2 won't compile

Steps to Reproduce

With

Version of Marlin Firmware

2.1.2.2

Printer model

Creality CR10S Pro

Electronics

No response

LCD/Controller

DGUS_LCD_UI_RELOADED

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Conf.zip

@ellensp ellensp added Bug: Confirmed ! Fix Included A fix is included in the description and removed Bug: Potential ? labels Mar 10, 2024
@ellensp
Copy link
Contributor

ellensp commented Mar 10, 2024

The ExtUI headers are not included...

apply this diff

diff --git a/Marlin/src/feature/powerloss.cpp b/Marlin/src/feature/powerloss.cpp
index 86e6b780bd..69e23f4a32 100644
--- a/Marlin/src/feature/powerloss.cpp
+++ b/Marlin/src/feature/powerloss.cpp
@@ -31,6 +31,10 @@
 #include "powerloss.h"
 #include "../core/macros.h"
 
+#if ENABLED(EXTENSIBLE_UI)
+  #include "../lcd/extui/ui_api.h"
+#endif
+
 bool PrintJobRecovery::enabled; // Initialized by settings.load()
 
 MediaFile PrintJobRecovery::file;

@ellensp
Copy link
Contributor

ellensp commented Mar 10, 2024

Issue is not present in bugfix 2.1.x

@Ale11Re
Copy link
Author

Ale11Re commented Mar 11, 2024

My bad, if not present in bugfix I screwed up something else

@thisiskeithb
Copy link
Member

Closing since this is already fixed in bugfix-2.1.x.

@thisiskeithb
Copy link
Member

Patch for 2.1.x submitted:

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed ! Fix Included A fix is included in the description
Projects
None yet
Development

No branches or pull requests

3 participants