-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] DGUS_LCD_UI_RELOADED not compiling Marlin 2.1.2.2 #26859
Labels
Comments
ellensp
added
Bug: Confirmed !
Fix Included
A fix is included in the description
and removed
Bug: Potential ?
labels
Mar 10, 2024
The ExtUI headers are not included... apply this diff diff --git a/Marlin/src/feature/powerloss.cpp b/Marlin/src/feature/powerloss.cpp
index 86e6b780bd..69e23f4a32 100644
--- a/Marlin/src/feature/powerloss.cpp
+++ b/Marlin/src/feature/powerloss.cpp
@@ -31,6 +31,10 @@
#include "powerloss.h"
#include "../core/macros.h"
+#if ENABLED(EXTENSIBLE_UI)
+ #include "../lcd/extui/ui_api.h"
+#endif
+
bool PrintJobRecovery::enabled; // Initialized by settings.load()
MediaFile PrintJobRecovery::file;
|
Issue is not present in bugfix 2.1.x |
My bad, if not present in bugfix I screwed up something else |
Closing since this is already fixed in |
This was referenced Apr 27, 2024
Patch for |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
When selecting DGUS_LCD_UI_RELOADED to compile with CR10s Pro. I'm providing my configurations. It does compile with Marlin 2.1.2.1. I did also try with latest Marlin bugfix 2.1.x but does not compile due to other errors. Compilation error: ExtUI not defined. When commenting line 111 of /src/feature/powerloss.cpp "TERN_(EXTENSIBLE_UI, ExtUI::onSetPowerLoss(enabled));" It compiles fine.
Bug Timeline
No response
Expected behavior
Expect Marlin 2.1.2.2 to compile
Actual behavior
Marlin 2.1.2.2 won't compile
Steps to Reproduce
With
Version of Marlin Firmware
2.1.2.2
Printer model
Creality CR10S Pro
Electronics
No response
LCD/Controller
DGUS_LCD_UI_RELOADED
Other add-ons
No response
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
Conf.zip
The text was updated successfully, but these errors were encountered: