-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Postprocessing for J-axis checks I-axis instead #26954
Comments
Upon further investigating and thinking about the axes b) might be working as designed and can be "fixed" by renaming the I axis to B in configuration.h instead of defining an J axis without an I axis. Line 183 in 311bfc9
This leaves the typo from a) as bug. If that is so, I can provide a pull request fixing the typo. |
Yes in Marlin the internal axis names must be used sequentially. You then give it the external name you want. Yes that is a typo you found. |
A pr has been created to fix this typo. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
When defining a configuration of a printer/cnc with an x, y, z and j axis, but no i axis (e.g. because the rotary axis is parallel to y and not to x), compiling fails because
a) a typo in
Marlin/Marlin/src/pins/pins_postprocess.h
Line 1250 in 311bfc9
which I assume should be
#if J_E_INDEX >= MAX_E_STEPPERS || !PIN_EXISTS(J_STEP)
instead.b) the way the code in
Marlin/Marlin/src/inc/Conditionals_LCD.h
Line 243 in 311bfc9
Marlin/Marlin/src/inc/Conditionals_LCD.h
Line 251 in 311bfc9
Compilation fails with
Bug Timeline
unknown
Expected behavior
Compilation should succeed with only J and no I axis.
Actual behavior
Comilation fails, with
Steps to Reproduce
Version of Marlin Firmware
2.1.x
Printer model
not relevant. Example Board: MINIRAMBO_CNC
Electronics
MINIRAMBO_CNC
LCD/Controller
ULTIPANEL
Other add-ons
none
Bed Leveling
None
Your Slicer
None
Host Software
None
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
Configuration_adv.zip
The text was updated successfully, but these errors were encountered: