Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RC4] Marlin RC4 doesn't support simple mechanical Z Probe? #3247

Closed
ghost opened this issue Mar 25, 2016 · 3 comments
Closed

[RC4] Marlin RC4 doesn't support simple mechanical Z Probe? #3247

ghost opened this issue Mar 25, 2016 · 3 comments
Labels
T: Feature Request Features requested by users.

Comments

@ghost
Copy link

ghost commented Mar 25, 2016

for example:
ATOM 2.0 Delta 3D Printer - Official Site
MICROMAKE 3D打印機DIY學習套件 注塑版 三角洲 並聯臂 Kossel-淘宝网全球站 ... my printer
Effector for Kossel mini with Z probe by wkkpatrick - Thingiverse
Detachable Z-probe w. magnetic connection for delta printer by robkar - Thingiverse

Marlin began to force that we select classification of probes,
since commit 1cc316f(PR #3082).
But these simple mechanical probes aren't sled, servo, inductive sensor, or the Allen key.

If I had to choose simple probe resembles the Allen key, but it doesn't needs deploys and retracts.
Therefore if I use simple probe as the Allen key(#define Z_PROBE_ALLEN_KEY),
it causes retract error in stow_z_probe() in Marlin_main.c.

      #if ENABLED(Z_MIN_PROBE_ENDSTOP)
        bool z_probe_endstop = (READ(Z_MIN_PROBE_PIN) != Z_MIN_PROBE_ENDSTOP_INVERTING);
        if (!z_probe_endstop)
      #else
        bool z_min_endstop = (READ(Z_MIN_PIN) != Z_MIN_ENDSTOP_INVERTING);
        if (!z_min_endstop)
      #endif
        {
          if (IsRunning()) {
            SERIAL_ERROR_START;
            SERIAL_ERRORLNPGM("Z-Probe failed to retract!");
            LCD_ALERTMESSAGEPGM("Err: ZPROBE");
          }
          Stop();
        }
@thinkyhead
Copy link
Member

Essentially it is an "Allen Key" style probe, and can be configured by treating it as one. Given that more of these kinds of probes are appearing, we might decide to change the name so it isn't so "allen key" specific, but refers to probes that follow procedures for initial deployment and final stowing. This has been on the general agenda for a while, but there have been other priorities superseding it.

Since you seem keen on the subject, please make a PR that makes it work the way it should – or just make a Feature Request, proposing how it should work, and we will keep it on the To-Do list. This issue right here would suffice, but at this point you should be targeting the MarlinDev branch for this request, because with the new release imminent, we have to close this tree to new features.

@ghost
Copy link
Author

ghost commented Mar 26, 2016

I bow to your wish, then I close this issue for release of RC5.
And, I challenge to make a PR for MarlinDev.

@ghost ghost closed this as completed Mar 26, 2016
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

1 participant