BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction #7902

fiveangle · 2017-10-08T19:46:26Z

Bug Report

Description: During G29 BILINEAR issues double-touch on some probe points, normal on others
Expected behaviour: Normal single probes
Actual behaviour: Issues double-touch probes on some points:
https://youtu.be/bpuzHJtRfeo
Steps to reproduce:
- Compile bugfix2.0.x with BILINEAR with 5 grid points and do not enable DOUBLETOUCH
- G28;G29
- Observe double-touch on some points

https://github.com/fiveangle/Marlin/blob/bf20-pb_simple_metal/Marlin/Configuration.h
https://github.com/fiveangle/Marlin/blob/bf20-pb_simple_metal/Marlin/Configuration_adv.h

Recv: echo:G28
Recv: echo:busy: processing
Recv: X:51.00 Y:76.00 Z:3.00 E:0.00 Count X:1020 Y:1520 Z:1521
Recv: ok P15 B3
[...]
Recv: echo:M105
[...]
Send: G29
Recv: echo:G29
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: echo:busy: processing
Recv: Bilinear Leveling Grid:
Recv:       0      1      2      3      4
Recv:  0 +0.138 +0.099 +0.067 +0.067 +0.075
Recv:  1 +0.028 -0.028 -0.071 -0.047 -0.039
Recv:  2 -0.006 -0.024 -0.049 -0.053 -0.069
Recv:  3 +0.059 +0.032 -0.004 -0.030 -0.075
Recv:  4 +0.036 -0.004 -0.020 -0.041 -0.061
Recv: 
Recv: X:124.00 Y:152.00 Z:3.05 E:0.00 Count X:2480 Y:3040 Z:1521
Recv: ok P15 B3

-=dave

Update: recompiled with LCD disabled and leveling debug enabled and behavior is same.

As visually represented looking at printer top-down (X indicates where double-touch occurs, as also shown in video linked to above):

00000
XX000
00000
X0000
XXXXX

Debug leveling output of G28; G29:

putty.log

I have never tested BILINEAR on the 2.0 branch until now (due to various compile errors which I've finally worked through all of) so unsure of if this is a recent regression or been there since the breakup.

UPDATE 10/14:
Tested with 1.1.6 and still present so this is a regression that's been there for a while (I'd been working on bringing up Re-ARM on this printer but reverted recently (Re-ARM has just some bare steppers on it now).

Compile same options on 1.1.6 or 1.1.5 with BILINEAR but 6 grid points and do not enable DOUBLETOUCH
Observe double-touch on bed area as seen with bugfix2.0.x, but observe the probe pattern is reversed, starting at far end of Y axis (due to the even number of grid lines across bed) so it seems this is related to the area of the bed and not specifically each probe point being tainted along the way.
Compile with 1.1.4 and double-touch issue is gone.

Probing code changes start around lines 2192/2229 (114/115) in Marlin_main.cpp in these diffs:
fiveangle/Marlin@114...fiveangle:115

[INSERT TIMELAPSE-OF-CLOCK-SPINNING-FORWARD-SEVERAL-HOURS HERE]

I think this code is responsible:

I suspect the probe deploy height added here, combined with my "0" deploy clearance (inductive sensor):

#define Z_CLEARANCE_DEPLOY_PROBE  0 // Z Clearance for Deploy/Stow
#define Z_CLEARANCE_BETWEEN_PROBES  3 // Z Clearance between probe points

Is causing double-touch on any areas of the bed that are lower than the G28 homeing Z point.

I haven't modified any FW or bisected 1.1.5 and 1.1.6 to test. If so, I'm not sure how best to address it though other than perhaps a hack to add a test that if Z_CLEARANCE_DEPLOY_PROBE is < Z_CLEARANCE_BETWEEN_PROBES, omit the newly added deploy test entirely.

The text was updated successfully, but these errors were encountered:

thinkyhead · 2017-11-15T10:07:33Z

Has this problem remained in the latest bugfix-1.1.x branch? If so, please re-open this issue.

fiveangle · 2017-12-03T01:06:40Z

No change as of 05f8e98

Can't re-open as I did not close it.

Roxy-3D · 2017-12-03T01:18:41Z

It's reopened for you...

fiveangle · 2017-12-03T02:40:27Z

Thx. Tried bisecting to narrow it down, but too many fundemental compile issues on Printrboard between 1.1.4 - 1.1.5. Have a feeling this will take a while 😝

Roxy-3D · 2017-12-03T04:16:35Z

Does anybody want to hear my feelings towards the Printrboard people? If so... Let's start a new thread so we don't screw this one up.

fiveangle · 2017-12-03T05:21:59Z

I thought you liked me @Roxy-3D ? 💋 😉

Unfortunately, I see little evidence to support this being Printrboard-specific. I suspect it's triggered via a specific configuration (it's just that I have so much custom config, even that is difficult to narrow down).

Roxy-3D · 2017-12-03T16:42:46Z

Does anybody want to hear my feelings towards the Printrboard people?

I guess I was sloppy with my English. I should have worded that more like "Does anybody want to hear my feelings towards the Printrbot company and its lack of support for the Printrboard?"

compatibilizer · 2017-12-13T19:00:41Z

It is not related to Printrboard. Also it is not a bug either. Probably expected behaviour. Let me explain;

@fiveangle did you set your "#define Z_CLEARANCE_DEPLOY_PROBE" to 0?

Set it to 1 and it will return to normal.

I did try to set it to 0 because I have a fixed probe, but later realized that it says only integer values >= 1 are applicable. This is probably required due to some equation about Z clearance calculation. Can this behaviour be improved? Probably yes, but I don't think this counts as a bug since there is a word of caution already in place.

fiveangle · 2017-12-13T21:01:11Z

I think the only person who thinks this might be related to Printrboard is Roxy, and that's more a running joke tongue-in-cheek than the truth :)

From my first post I state my suspicion of the Z_CLEARANCE_DEPLOY_PROBE = 0 being the issue. But there is no reason it should not be supported and for behavior to change. I do see the detail on in the Config.h, but from SanityCheck.h:

https://github.com/MarlinFirmware/Marlin/blob/bugfix-1.1.x/Marlin/SanityCheck.h#L693-L701 :

  #ifndef Z_CLEARANCE_DEPLOY_PROBE
    #error "You must define Z_CLEARANCE_DEPLOY_PROBE in your configuration."
  #elif !defined(Z_CLEARANCE_BETWEEN_PROBES)
    #error "You must define Z_CLEARANCE_BETWEEN_PROBES in your configuration."
  #elif Z_CLEARANCE_DEPLOY_PROBE < 0
    #error "Probes need Z_CLEARANCE_DEPLOY_PROBE >= 0."
  #elif Z_CLEARANCE_BETWEEN_PROBES < 0
    #error "Probes need Z_CLEARANCE_BETWEEN_PROBES >= 0."
  #endif

"Probes need Z_CLEARANCE_DEPLOY_PROBE >= 0."

I will confirm again that this behavior was not present in 1.1.4 and is present in 1.1.5 (since managing checkout, compile, shuffling Marlin.hex / firmware.hex to/from octoprint, dfu-util, etc there is always the possibility for human error).

But it's definitely not WAD. The issue must be fixed, either by forcing Z_CLEARANCE_DEPLOY_PROBE to be within the required range via SantityCheck.h (the hack solution) or determining where the indeterminant behavior is being injected when Z_CLEARANCE_DEPLOY_PROBE becomes 0.

Most of the commits leading up to 1.1.5 fail to compile for Printrboard due to unrelated issues so I can't test right now, and I'm not looking too forward to figuring out which ones require backporting just so I can get it to compile to then do a bisect search through the 114-115 changes to find the culprit.

But an easy immediate solution would be to submit the "hack" solution for now, and keep this open for the long-term "todo" fix.

-=dave

fiveangle · 2018-01-24T17:08:12Z

No longer interested in figuring out where it broke. Closing...

github-actions · 2021-01-20T14:30:41Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

fiveangle changed the title ~~[bf2.0.x] BILINEAR issues double-touch on some probe points, normal on others~~ BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction Oct 14, 2017

thinkyhead closed this as completed Nov 15, 2017

thinkyhead added Bug: Potential ? F: Calibration labels Nov 15, 2017

Roxy-3D reopened this Dec 3, 2017

fiveangle closed this as completed Jan 24, 2018

fiveangle mentioned this issue Jun 26, 2020

Fix probe clearance calculation (#17242) #18435

Merged

github-actions bot locked and limited conversation to collaborators Jan 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction #7902

BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction #7902

fiveangle commented Oct 8, 2017 •

edited

Loading

thinkyhead commented Nov 15, 2017

fiveangle commented Dec 3, 2017

Roxy-3D commented Dec 3, 2017

fiveangle commented Dec 3, 2017 •

edited

Loading

Roxy-3D commented Dec 3, 2017

fiveangle commented Dec 3, 2017 •

edited

Loading

Roxy-3D commented Dec 3, 2017

compatibilizer commented Dec 13, 2017

fiveangle commented Dec 13, 2017 •

edited

Loading

fiveangle commented Jan 24, 2018

github-actions bot commented Jan 20, 2021

BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction #7902

BILINEAR issues double-touch on some probe points, normal on others, erratic prob direction #7902

Comments

fiveangle commented Oct 8, 2017 • edited Loading

Bug Report

thinkyhead commented Nov 15, 2017

fiveangle commented Dec 3, 2017

Roxy-3D commented Dec 3, 2017

fiveangle commented Dec 3, 2017 • edited Loading

Roxy-3D commented Dec 3, 2017

fiveangle commented Dec 3, 2017 • edited Loading

Roxy-3D commented Dec 3, 2017

compatibilizer commented Dec 13, 2017

fiveangle commented Dec 13, 2017 • edited Loading

"Probes need Z_CLEARANCE_DEPLOY_PROBE >= 0."

fiveangle commented Jan 24, 2018

github-actions bot commented Jan 20, 2021

fiveangle commented Oct 8, 2017 •

edited

Loading

fiveangle commented Dec 3, 2017 •

edited

Loading

fiveangle commented Dec 3, 2017 •

edited

Loading

fiveangle commented Dec 13, 2017 •

edited

Loading