Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] M73 Enhancements #9178

Closed
benlye opened this issue Jan 14, 2018 · 3 comments
Closed

[FR] M73 Enhancements #9178

benlye opened this issue Jan 14, 2018 · 3 comments

Comments

@benlye
Copy link
Contributor

benlye commented Jan 14, 2018

M73 currently takes a single P parameter to manually set the progress bar percentage. There is a new OctoPrint plugin, M73Progress, which will update the progress bar by periodically sending M73 commands.

The first thing I found is that LCD_SET_PROGRESS_MANUALLY requires SDSUPPORT, but with a couple of simple changes that dependency can be removed (I don't have an SD reader and don't particularly want full SD support enabled).

Then I thought it would be neat to also be able to update the timer above the progress bar, either with time elapsed or time remaining. Something like M73 T[seconds].

Any thoughts on those two changes? I'm happy to put together a PR here and for the OctoPrint plugin.

@benlye
Copy link
Contributor Author

benlye commented Jan 16, 2018

I've been tinkering around with this and have found a couple of interesting bugs with the progress bar:

  • A progress time of >= 100 days (8640000 seconds) will cause Marlin to reset
  • A progress time of exactly 1 day (86400 seconds) displays incorrectly as 00:00 instead of 1 day 00:00

A print time of 100 days is pretty unlikely, but I figure having Marlin reset for something like that is uncool, and avoidable. I'll submit a separate patch for those.

@benlye
Copy link
Contributor Author

benlye commented Jan 16, 2018

Created #9202 and #9203 to address the display issue when the time is exactly 86400s.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants