Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in src/clib/u8g.h#L451 #32

Closed
ellensp opened this issue Dec 27, 2023 · 3 comments
Closed

Typo in src/clib/u8g.h#L451 #32

ellensp opened this issue Dec 27, 2023 · 3 comments

Comments

@ellensp
Copy link

ellensp commented Dec 27, 2023

u8g.h Has

/* OLED 128x64 Display with SSD1309 Controller - Fast Single Page */
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_sw_spi;
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_hw_spi;
extern u8g_dev_t u8g_dev_ssd1309_128x64_f_sw_spi;

But last line should be

extern u8g_dev_t u8g_dev_ssd1309_128x64_f_i2c;

Also in platformio the download https://dl.registry.platformio.org/libraries/6b/fa/5589b9bdde2f8434f3753af1e086f7415ace71f9e7e05c486d3f3e656675/U8glib-HAL-0.5.3.tar.gz the updated u8g.h is not present
It can also be seen as missing in .pio/libdeps/{env}/U8glib-HAL/src/clib/u8g.h
which I cannot explain, its there if I download the library manually from github

@ellensp ellensp changed the title Typo in rc/clib/u8g.h#L451 Typo in src/clib/u8g.h#L451 Dec 27, 2023
@dbuezas
Copy link
Contributor

dbuezas commented Dec 27, 2023

Oh no, that's my fault. I don't have a computer at the moment to make a new PR, sorry for that.

@thisiskeithb
Copy link
Member

thisiskeithb commented Dec 27, 2023

There may have been some force-pushing going on since e258d50 and 36f7670 exist with a "Version 0.5.3" commit title.

I suspect PIO isn't picking up the updated code and another tag (and release?) is in order once this bug has been fixed. cc: @thinkyhead

@thinkyhead
Copy link
Member

Oh no, that's my fault.

Mea culpa. The buck stops here. I should have actually done some builds before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants