Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development info in README/wiki is outdated and won't build. #3803

Open
3 tasks done
eth-p opened this issue Mar 3, 2020 · 3 comments
Open
3 tasks done

Development info in README/wiki is outdated and won't build. #3803

eth-p opened this issue Mar 3, 2020 · 3 comments

Comments

@eth-p
Copy link
Contributor

eth-p commented Mar 3, 2020

Checklist:

OS:
MacOS Mojave

GPMDP Version:
git master branch.

Issue Descriptions:
The documentation for building the project is out of date, and it fails to build on MacOS.

Steps to Reproduce:

git clone "git@github.com:eth-p/Google-Play-Music-Desktop-Player-UNOFFICIAL-.git" gpmdp
cd gpmdp
npm install   # Errors
npm run build # Errors

Recommended changes:

  1. Suggest Node 8 for MacOS. Versions prior to NodeJS v8.0 will fail to compile node-gyp modules due to a breaking change that Apple made to Xcode/command line tools (Node.js 6.x on macOS / Xcode 10.1 failing to compile (libc++) nodejs/node#24648).

  2. Replace npm install with yarn install (building windows binary fails under wsl and ubuntu vm #3591 (comment)).

@welcome
Copy link

welcome bot commented Mar 3, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of duplicate issues on this repo, so please double check now that your issue has not already been solved or doesn't have an open issue already.

To help make it easier for us to investigate your issue, please follow the contributing guidelines and ensure the issue template was filled out.

@FerLuisxd
Copy link

FerLuisxd commented Apr 27, 2020

This also happens with windows 10 && debian 10

I have an issue compiling runas on both platforms

@FerLuisxd
Copy link

@MarshallOfSound sorry for the ping but can you check this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants