Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More permissive license? #7

Closed
natan-abolafya opened this issue Dec 22, 2022 · 9 comments
Closed

More permissive license? #7

natan-abolafya opened this issue Dec 22, 2022 · 9 comments

Comments

@natan-abolafya
Copy link

natan-abolafya commented Dec 22, 2022

Hey.

Came across your library on this discussion and decided to give it a try and it worked quite nicely. Only noticed at the last second that it's GPL licensed. Any chance you could use a more permissive license like MIT or Apache 2.0?

@natan-abolafya natan-abolafya changed the title More relaxed License More relaxed license Dec 22, 2022
@natan-abolafya natan-abolafya changed the title More relaxed license More relaxed license? Dec 22, 2022
@natan-abolafya natan-abolafya changed the title More relaxed license? More permissive license? Dec 22, 2022
@MartinKuschnik
Copy link
Owner

Hey,

ich have changed the license to MIT. Have fun with it.

What kind of project do you are using WmiLight?

@natan-abolafya
Copy link
Author

Fantastic! Thank you.

It's an enterprise level desktop application where we gather a couple of information about Windows such as Windows version and device Id. We don't depend on WMI that much but we need that information in the way WMI reports.
Our goal wasn't to fix the memory leak you mentioned in the readme, but rather move away from COM.

@natan-abolafya
Copy link
Author

Apparently, I have tested this wrong before. WmiLight seems to be using COM also as the calls seem to be failing with

WMI failed while retrieving device ID. Built-in COM has been disabled via a feature switch. See https://aka.ms/dotnet-illink/com for more information.

now.

@MartinKuschnik
Copy link
Owner

WmiLight uses also COM :-(

@natan-abolafya
Copy link
Author

It's possible that this comment meant that trimming works better even when COM is enabled on the project. I will try that next.

@MartinKuschnik
Copy link
Owner

MartinKuschnik commented Dec 27, 2022

Ok, meaning you would like to shink the size of your application by using the trimming function during build?

@MartinKuschnik
Copy link
Owner

Partial trim woks if this is an option.

<BuiltInComInteropSupport>true</BuiltInComInteropSupport>
<TrimMode>partial</TrimMode>

@natan-abolafya
Copy link
Author

On .NET 6, I was already using <TrimMode>CopyUsed</TrimMode> with System.Management library and it was working. But I wanted to use the Link mode, which I'm guessing means Full on .NET 7; and that was crashing.

I've enabled COM with WmiLight now and the full trim mode, it's working better than System.Management which is great. So I guess that's what the commenter meant.

@MartinKuschnik
Copy link
Owner

Ok, very nice.

Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants