New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow rule name duplicates #11

Open

MartinLoeper opened this issue Jul 8, 2017 · 4 comments

Labels

bug help wanted Priority 3

Owner

MartinLoeper commented Jul 8, 2017

The user must not enter rules with the same identifier.
Is there an xText grammar features which ensures that duplicates produce an error?

MartinLoeper added the bug label

Owner Author

MartinLoeper commented Jul 11, 2017

This seams to be accomplished by the xText type ValidID.
We do not have to implement anything at all.

MartinLoeper closed this as completed

Owner Author

MartinLoeper commented Jul 11, 2017

This was proved wrong. We need to write a custom validator such as: https://stackoverflow.com/questions/32126903/validating-unique-names-for-strings-and-optional-reference

MartinLoeper reopened this

Owner Author

MartinLoeper commented Jul 11, 2017

Setting the want help marker here in order to ask Dominik.

MartinLoeper added the help wanted label

dwerle commented Jul 18, 2017

Custom Validator should be the way to go. The Vitruvius reactions language implements basically the same thing:
ReactionsLanguageValidator#checkReactionsFile (in https://github.com/vitruv-tools/Vitruv/blob/master/bundles/dsls/tools.vitruv.dsls.reactions/src/tools/vitruv/dsls/reactions/validation/ReactionsLanguageValidator.xtend)

MartinLoeper added the Priority 3 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment