Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Interval continues to run after leaving page. #3

Closed
chungchunwang opened this issue Dec 4, 2022 · 2 comments
Closed

Bug - Interval continues to run after leaving page. #3

chungchunwang opened this issue Dec 4, 2022 · 2 comments

Comments

@chungchunwang
Copy link
Contributor

Hi! First of all, thanks for making this plugin! I have found a small bug with it though, which is that the action linked to the interval continues to run even after navigating to a new page.
@chungchunwang chungchunwang mentioned this issue Dec 4, 2022
Merged
@chungchunwang
Copy link
Contributor Author

I submitted a pull request which should fix this: #4
I went in and added a couple of lines that deletes the interval in onDestroy(). This (at least in my tests) resolves the issue.

@MartinPicc
Copy link
Owner

Hi,
Thank you very much for contributing, looks all good to me, I merged your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinPicc @chungchunwang