Allow string for cpuFrequency and swoFrequency

[mm-mm-bb]

I need to support different chip with clock speed.
The setup is:

• in the CMakePresets.json, each preset define a cacheVariables with the desired clock speed
• cmake will save that variables inside of the .vscode/settings.json
• in the launch.json i assign the variable to the "swoConfig.cpuFrequency"

Unfortunately, while this work for stuff like the swoPort, on the cpuFrequency field i get error "Expected "number"."

Describe the solution you'd like
Allow cpuFrequency and swoFrequency (but really any numeric field) to be a string.
Something similar was implemented here: https://github.com/microsoft/vscode-js-debug/pull/1880/files

Describe alternatives you've considered
CMake would have to edit the launch.json and not only the setting.json.
(launch.json using cacheVariables directly would NOT fix, as seems ${} must be in quotes to work)

[haneefdm]

Show me what your launch.json line for swoConfig.cpuFrequency looks like now and after the change. I am not understanding

[mm-mm-bb]

this works

  "swoConfig":{
      [...]
      "swoFrequency": 2250000,
      [...]
   }

this does not work (not a number error)

  "swoConfig":{
      [...]
      "swoFrequency": "${config:target_core_clock}",
      [...]
   }

this does not work (unrecognized syntax)

  "swoConfig":{
      [...]
      "swoFrequency": ${config:target_core_clock},
      [...]
   }

target_core_clock is defined in .vscode/settings.json. Im using other variables set there, for example "svdFile": "${config:TARGET_SVD}", and that is fine

[mm-mm-bb]

ok, took a little look at the code unfortunately is my first time looking at .ts.
seems like some of the field are string, some are numerics:

cortex-debug/src/common.ts

Line 199 in 8210ae4

export interface SWOConfiguration {

not sure if the fix is as easy as changing to string, as that may break existing setups; maybe string|number is possible?

@haneefdm if you give me a hint on what is the best solution, i may give a try this weekend :)

[haneefdm]

Not sure there are any good solutions here. We have a dozen or so variables like this used by a bunch of different modules. You can make same argument for booleans and now, there are a lot more.

We can't just mass convert as we don't know what true type a given module is expecting. So, all modules have to be modified at the point of use.

Unfortunately, cpuFrequency and swoFrequency are used in calculations in multiple modules and are also passed to OpenOCD TCL scripts