Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more quickfixes #182

Closed
oblitum opened this issue Dec 28, 2018 · 3 comments
Closed

No more quickfixes #182

oblitum opened this issue Dec 28, 2018 · 3 comments

Comments

@oblitum
Copy link

oblitum commented Dec 28, 2018

As reported on coc.nvim gitter channel, ccls used to work when coc sent request on code action about quickfixes. It works on latest ccls release, doesn't work on lastest commit anymore.

@MaskRay
Copy link
Owner

MaskRay commented Dec 28, 2018

Fixed in 0.20181225.2

// src/messages/textDocumnt_code.cc
void MessageHandler::textDocument_codeAction(CodeActionParam &param,
                                             ReplyOnce &reply) {
...
  for (Diagnostic &diag : diagnostics)
    if (diag.fixits_.size() &&
        (param.range.Intersects(diag.range) ||  ////////// use Intersects
         llvm::any_of(diag.fixits_, [&](const TextEdit &edit) {
           return param.range.Intersects(edit.range);
         }))) {

@MaskRay MaskRay closed this as completed Dec 28, 2018
@oblitum
Copy link
Author

oblitum commented Dec 28, 2018

I tested on lastest master commit, it's same commit as that release.

@oblitum
Copy link
Author

oblitum commented Dec 28, 2018

Ops, sorry, I was grabbing some cache not latest. It's fixed on tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants