Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate potential solution to a performance bottleneck during cert chain validation #309

Closed
MasterKale opened this issue Dec 15, 2022 · 1 comment

Comments

@MasterKale
Copy link
Owner

There's been a TODO in validateCertificatePath() that notes a long-time bottleneck in the execution of the library:

// TODO: updateHex() takes approximately two seconds per execution, can we improve this?

I was playing around tonight and think I've discovered a fix for this using the new signature verification logic added in #299. Preliminary testing showed a 60% reduction in unit test execution time; I need to test this out in a server (probably use the FIDO Conformance testing server in the example project) and see if similar gains can be observed in something resembling actual use.

Perhaps this will also solve the performance issues noted in #308 when using @simplewebauthn/server in lambdas.

@MasterKale
Copy link
Owner Author

Addressed in #311.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant