glide ignore packages in test files

[hvnsweeting]

when I run glide guess/glide pin, they showed list of packages but missing those that I use for *_test.go.
Is that a feature or should it be fixed?

Thanks

[mattfarina]

I had not thought about this before. What's happening here is the go/build package has two separate things for imports. Imports is for your code and TestImports is for any imports in test code. We are just using the former and end up missing test imports.

Should test imports be on the Imports list in the yaml file or should they be on devImports?

@technosophos any thoughts on this?

[technosophos]

My initial intent when I added devImports was for test and build dependencies.

[davecgh]

I see the opposite with https://github.com/syndtr/goleveldb. There are several dependencies that are only needed to run the tests which are included in the imports section of the lock file.

Glide should gain a -t flag (or an aptly named option in the yaml) just like go get has in my opinion. Specifically:

The -t flag instructs get to also download the packages required to build
the tests for the specified packages.

One of the primary purposes of glide is, of course, to provide reproducible builds and installs to end user and developers alike. To that end, testing of dependencies is squarely aimed more at developers than end users and thus should really be opt-in with a flag/optional keyword, just like go get does it. A normal end user will typically want to the produce the final stable binary without needing or wanting to download the additional packages only needed for testing, particularly of dependencies.

It is slightly debatable whether the test-only dependencies of the project itself are included by default, but packages only required by the tests in dependencies should most definitely not be included given the version was specifically pinned because it is already known good and tested.

[krancour]

I am running into this as well. I have a project of just integration tests written in go.

My workaround has been to include a dummy non-test file that looks like this:

package tests

import (
    // This is a workaround for the fact that glide seems not to recursively resolve packages needed
    // only for testing.
    _ "k8s.io/kubernetes/pkg/client/unversioned"
)

But I'd rather not have to do that, obviously.

[mattfarina]

I've added #320 to track resolving test imports.

[mattfarina]

Please see #461 which is trying to fix the management of test imports. Reviews appreciated.

[mattfarina]

Fixed. Tip of master now handles test imports.