Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use etcd 2.2.4 anymore #231

Closed
hectorj opened this issue Jan 27, 2016 · 2 comments
Closed

Can't use etcd 2.2.4 anymore #231

hectorj opened this issue Jan 27, 2016 · 2 comments
Labels

Comments

@hectorj
Copy link
Contributor

hectorj commented Jan 27, 2016

You can check with this glide.yaml:

package: testEtcdGlide
import:
- package: github.com/coreos/etcd
  version: 2.2.4

Here is what it gives with the new master (aaf314c):

$ glide up
[INFO] Fetching updates for github.com/coreos/etcd.
[INFO] Detected semantic version. Setting version for github.com/coreos/etcd to v2.2.4.
[INFO] Resolving imports
[INFO] Found Godeps.json file.
[INFO] Setting version for google.golang.org/cloud to f20d6dcccb44ed49de45ae3703312cb46e627db1.
[INFO] Setting version for golang.org/x/net to 7dbad50ab5b31073856416cdcfeb2796d682f844.
[INFO] Setting version for github.com/golang/protobuf to 5677a0e3d5e89854c9974e1256839ee23f8233ca.
[INFO] Setting version for golang.org/x/oauth2 to 3046bc76d6dfd7d3707f6640f85e42d9c4050f50.
[ERROR] Dependency /tmp/gopath/src/testEtcdGlide/vendor/google.golang.org/api/container/v1beta1 failed to resolve: lstat /tmp/gopath/src/testEtcdGlide/vendor/google.golang.org/api/container/v1beta1: no such file or directory.
[ERROR] Failed to retrieve a list of dependencies: lstat /tmp/gopath/src/testEtcdGlide/vendor/google.golang.org/api/container/v1beta1: no such file or directory

But it works if I revert Glide to f8f0647

@mattfarina mattfarina added bug and removed bug labels Jan 27, 2016
@mattfarina
Copy link
Member

There is a problem here. I'm trying to figure out the best way to handle it.

Under Glide 0.8.3 there are no errors. But google.golang.org/cloud is set to f20d6dcccb44ed49de45ae3703312cb46e627db1 and it has an import of google.golang.org/api/container/v1beta1. Glide 0.8.3 checkout out google.golang.org/api as master where this package doesn't exist. So, it's not catching the problem even though it is present.

Glide on master catches this problem.

coreos, using Godep, vendors google.golang.org/cloud and it is listed in the Godeps.json file. But, google.golang.org/api is not vendored.

I think the fix is for Glide to walk the used dependency tree rather than all possibilities. Coreos must not be using the part of google.golang.org/cloud that calls to google.golang.org/api/container/v1beta1.

This may be solved by #220 or some of the other work we've talked about.

@mattfarina mattfarina added the bug label Jan 27, 2016
@hectorj
Copy link
Contributor Author

hectorj commented Jan 28, 2016

I wasn't sure if it was a bug in the old version or the new one, thanks for the investigation. It should indeed be fixed when issue #166 is resolved.

Temporary fix in case someone has the exact same issue : add

ignore:
- google.golang.org/api

to your glide.yaml

Closing.

@hectorj hectorj closed this as completed Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants