Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect tags from commit ids for conflict resolution #353

Closed
mattfarina opened this issue Mar 24, 2016 · 3 comments
Closed

Detect tags from commit ids for conflict resolution #353

mattfarina opened this issue Mar 24, 2016 · 3 comments
Milestone

Comments

@mattfarina
Copy link
Member

When resolving conflicts and possibly importing from others lock files detect tags associated with a listed commit. This will aide automating the SemVer handling.

See Masterminds/vcs#19 for implementation details with the VCS. This can be done fairly easily.

@mattfarina mattfarina added this to the 0.11 milestone Mar 24, 2016
@technosophos
Copy link
Member

That is a fabulous idea. Knowing that a commit ties to a tag actually makes life much easier for us.

@sdboyer
Copy link
Member

sdboyer commented Mar 24, 2016

big ups here. support for this is also on my TODO list in the solver.

ideally, the lock files generated should include both a tag (when applicable) and a revision. it doesn't actually obviate the need for this check - it mostly allows us to detect if/when upstream does something naughty and moves a tag. so...sorta related to this.

@mattfarina
Copy link
Member Author

It's now displayed. See #459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants