Glide fails when a git sha ref is provided

[ryanking]

As far as I can tell, the process for updating a vendored dependency is to a git ref, it appears to not be able to update it. I'm trying to dig in an find out why, but one problem I found is that it runs a git fetch and pull, even when on a detached head, which is going to fail with git.

[technosophos]

I believe that we used to do a git fetch --all and then do a git checkout to do this before. IIRC (and I'm working from memory here), that worked even on detached heads.

[mattfarina]

I know what the issue is. Will fix it soon.

[mattfarina]

Now that Masterminds/vcs#3 has been fixed can you try this again and let me know if it's fixed. The issue was in that project.

If you grab master go get -u github.com/Masterminds/glide you can test it instead of a binary. If you already retrieved it that way you may need to go get -u github.com/Masterminds/vcs first to get that fix.

Basically, Update() on a git repo needed to only pull when not in a detached head state. Pulling in a detached head state causes the error you saw.

[mattfarina]

@technosophos should we do a new build? Maybe a 0.5.2 release? The change was in a dependency so the only change for those using a binary would be the CHANGELOG. But, it would help anyone using a binary copy rather than getting via go get.

Thoughts?

[mattfarina]

Note, i've tested the fix and everything appears to be working.

[technosophos]

Yes, we should do a release for this.

[mattfarina]

0.6.0 is tag and being released. Closing with the release.