Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS-76: Something hosed w git submodules handling #76

Closed
m0j0hn opened this issue Apr 18, 2017 · 2 comments
Closed

VCS-76: Something hosed w git submodules handling #76

m0j0hn opened this issue Apr 18, 2017 · 2 comments

Comments

@m0j0hn
Copy link
Contributor

m0j0hn commented Apr 18, 2017

I am trying to use Glide on Linux and Windows, and for one of my modules with submodules, it's failing on Windows. Some Googling revealed Glide issue #745, which referenced line 388 in git.go.
After manually trying the underlying git commands on my Windows, I think root cause is that "git submodule foreach ... --prefix=..." passes the prefix string as a doublequote delimited string to Windows bash, and the trailing '' (Windows PathDelimiter) escapes the closing doublequote, which Breaks Things (tm). My inelegant solution is to create helper function which is used to conditionally rewrite the path string on Windows by tripling every PathDelimiter, i.e., '' becomes '\' - and this seems to solve the problem. I also added another test using a publicly accessible repo which exercised the original problem which led me to work on this in the first place.

@m0j0hn m0j0hn changed the title Something hosed w git submodules handling VCS-76: Something hosed w git submodules handling Apr 18, 2017
@m0j0hn
Copy link
Contributor Author

m0j0hn commented Apr 21, 2017

@mattfarina @technosophos Can you please consider this Issue and the PR for its fix?
#77

@mattfarina
Copy link
Member

I merged the PR. I'll update glide in the next couple days when I get a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants