Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MySQL 8 SRID? #27

Closed
sikhlana opened this issue Feb 28, 2022 · 6 comments
Closed

Support for MySQL 8 SRID? #27

sikhlana opened this issue Feb 28, 2022 · 6 comments

Comments

@sikhlana
Copy link

I have been using https://github.com/grimzy/laravel-mysql-spatial/ which has support for SRIDs. I am planning to migrate to this package as it has greater potential with Laravel's current ecosystem.

But looking at the source code, I don't see any support for SRID which will conflict with my current database schema. Is there any plan or are you interested in a PR?

@MatanYadaev
Copy link
Owner

Hi @sikhlana! I have no experience with SRID and I never needed it, so I didn't implement support for SRID.

I will be very happy if you could send a PR. Just make sure it has a good testing coverage.

Thanks so much.

@MatanYadaev
Copy link
Owner

@sikhlana There's something I can help with in order to push this task forward?

@MatanYadaev
Copy link
Owner

@sikhlana I closed the issue. If the issue is still relevant to someone, please contact me or just submit a PR.

@sikhlana
Copy link
Author

@MatanYadaev apologies for the late reply. I have been busy with a high priority project so not getting the time to add support for SRIDs. Will be able to come up with something within a few days.

@Gemui
Copy link

Gemui commented Jul 13, 2022

I created pull request for SRID support #42

@MatanYadaev
Copy link
Owner

@sikhlana Implemented in v2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants