Merge pull request #34306 from def-/pr-statement-logging-99

tests: Switch us to 100% statement logging by default

Author: def-

misc/python/materialize/mzcompose/__init__.py

@@ -370,10 +370,14 @@ def get_variable_system_parameters(
         ),
         VariableSystemParameter("pg_offset_known_interval", "1s", ["100ms", "1s"]),
         VariableSystemParameter(
-            "statement_logging_default_sample_rate", "0.01", ["0", "0.01"]
+            "statement_logging_default_sample_rate",
+            "1.0",
+            ["0", "0.01", "0.5", "0.99", "1.0"],
         ),
         VariableSystemParameter(
-            "statement_logging_max_sample_rate", "0.01", ["0", "0.01"]
+            "statement_logging_max_sample_rate",
+            "1.0",
+            ["0", "0.01", "0.5", "0.99", "1.0"],
         ),
         VariableSystemParameter("storage_reclock_to_latest", "true", ["true", "false"]),
         VariableSystemParameter(

test/testdrive/session.td

@@ -76,9 +76,9 @@ server_version                           9.5.0                   "Shows the Post
 server_version_num                       90500                   "Shows the PostgreSQL compatible server version as an integer (PostgreSQL)."
 sql_safe_updates                         off                     "Prohibits SQL statements that may be overly destructive (CockroachDB)."
 standard_conforming_strings              on                      "Causes '...' strings to treat backslashes literally (PostgreSQL)."
-statement_logging_default_sample_rate    0.01                    "The default value of `statement_logging_sample_rate` for new sessions (Materialize)."
-statement_logging_max_sample_rate        0.01                    "The maximum rate at which statements may be logged. If this value is less than that of `statement_logging_sample_rate`, the latter is ignored (Materialize)."
-statement_logging_sample_rate            0.01                    "User-facing session variable indicating how many statement executions should be logged, subject to constraint by the system variable `statement_logging_max_sample_rate` (Materialize)."
+statement_logging_default_sample_rate    1.0                     "The default value of `statement_logging_sample_rate` for new sessions (Materialize)."
+statement_logging_max_sample_rate        1.0                     "The maximum rate at which statements may be logged. If this value is less than that of `statement_logging_sample_rate`, the latter is ignored (Materialize)."
+statement_logging_sample_rate            1.0                     "User-facing session variable indicating how many statement executions should be logged, subject to constraint by the system variable `statement_logging_max_sample_rate` (Materialize)."
 statement_timeout                        "1 min"                  "Sets the maximum allowed duration of INSERT...SELECT, UPDATE, and DELETE operations. If this value is specified without units, it is taken as milliseconds."
 superuser_reserved_connections           3                       "The number of connections that are reserved for superusers (PostgreSQL)."
 TimeZone                                 UTC                     "Sets the time zone for displaying and interpreting time stamps (PostgreSQL)."