Commit fa7b3d1
authored
[observability] fix
@ggevay noticed that `EXPLAIN ANALYZE CPU FOR INDEX
mz_internal.mz_console_cluster_utilization_overview_ind;` was returning
empty results. It turns out that `mz_internal.mz_mappable_objects`
assumed that every object it worked with lived in a database, but this
is not the case for objects in `mz_internal`. Changing the join on
`mz_databases` to be a `LEFT JOIN` should resolve the issue.
I did not bother doing something similar for the schema, as I believe
every object must live in a schema. I extended the `EXPLAIN ANALYZE`
testdrive to account for this bug.
### Motivation
* This PR fixes a recognized bug.
Original message:
https://materializeinc.slack.com/archives/C08ACQNGSQK/p1763565268661699
Follow-up thread:
https://materializeinc.slack.com/archives/C08ACQNGSQK/p1763565268661699
### Checklist
- [ ] This PR has adequate test coverage / QA involvement has been duly
considered. ([trigger-ci for additional test/nightly
runs](https://trigger-ci.dev.materialize.com/))
- [ ] This PR has an associated up-to-date [design
doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md),
is a design doc
([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)),
or is sufficiently small to not require a design.
<!-- Reference the design in the description. -->
- [ ] If this PR evolves [an existing `$T ⇔ Proto$T`
mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md)
(possibly in a backwards-incompatible way), then it is tagged with a
`T-proto` label.
- [ ] If this PR will require changes to cloud orchestration or tests,
there is a companion cloud PR to account for those changes that is
tagged with the release-blocker label
([example](MaterializeInc/cloud#5021)).
<!-- Ask in #team-cloud on Slack if you need help preparing the cloud
PR. -->
- [ ] If this PR includes major [user-facing behavior
changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note),
I have pinged the relevant PM to schedule a changelog post.EXPLAIN ANALYZE to work on objects that are not in a database (#34216)1 parent 66d8f67 commit fa7b3d1
2 files changed
+80
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6174 | 6174 | | |
6175 | 6175 | | |
6176 | 6176 | | |
6177 | | - | |
| 6177 | + | |
6178 | 6178 | | |
6179 | | - | |
6180 | | - | |
6181 | | - | |
6182 | | - | |
| 6179 | + | |
| 6180 | + | |
| 6181 | + | |
| 6182 | + | |
6183 | 6183 | | |
6184 | 6184 | | |
6185 | 6185 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
0 commit comments