adapter: extract an OptimizerCatalog trait #29598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This will help with continual tasks, which need to inject an entry for the CT itself before it exists in the catalog, but also it gets us one step closer to pulling the optimizer into its own crate. I also switched over a few more `adapter::optimize::*::Optimizer` structs, but had to leave a few because it gets tricky with `ExprPrepStyle::OneShot` and `eval_unmaterializable_func`. Touches #28899
danhhz
force-pushed
the
optimizer_catalog
branch
from
30fae38
to
83e407e
Compare
danhhz
changed the title
|
This should be ready for review! |
teskje
reviewed
Sep 23, 2024
|
TFTRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with continual tasks, which need to inject an entry for
the CT itself before it exists in the catalog, but also it gets us one
step closer to pulling the optimizer into its own crate.
I also switched over a few more
adapter::optimize::*::Optimizerstructs, but had to leave a few because it gets tricky with
ExprPrepStyle::OneShotandeval_unmaterializable_func.Touches MaterializeInc/database-issues#8427
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.