Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub code owners for the specification #341

Open
ml-evs opened this issue Nov 25, 2020 · 2 comments
Open

Add GitHub code owners for the specification #341

ml-evs opened this issue Nov 25, 2020 · 2 comments
Labels
status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus.

Comments

@ml-evs
Copy link
Member

ml-evs commented Nov 25, 2020

I raised in the last meeting that it might make sense to add GitHub "code owners" to the optimade.rst file, which are required to review any PRs before merging (instead of the scattergun approach we take at the moment, where the PR author has to choose from a list of 50 people).

This artificially elevates some members of the community, but currently we are vulnerable to features getting pushed through without consensus.

This would simply require creation of a CODEOWNERS file under .github/ following https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners

This could even be split down by branch (slightly awkwardly requires different CODEOWNERS files on each branch) so that "fixes" to whatever branch ends up tracking v1.0.x (see #340) only requires 1 or 2 reviewers, whereas new features could require multiple code owners to agree (say 1 per major implementation).

There would obviously be an acceptance that new features are therefore dealt with much more slowly.

@ml-evs ml-evs added the status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. label Nov 25, 2020
@ml-evs ml-evs changed the title Add code owners for the specification Add GitHub code owners for the specification Nov 25, 2020
@merkys
Copy link
Member

merkys commented Nov 27, 2020

An alternative proposal would be to increase the number of required reviews (currently 2). However, this would not prevent "gangs" from pushing their proposals 😉, only make that somewhat harder.

@ml-evs
Copy link
Member Author

ml-evs commented Dec 22, 2022

Coming back to this idea, I think this would be a nice way of handling the develop->master and final release process.

It would probably make sense to have the "nominated" release managers for each release as required reviewers for the final PR to master. We can think about doing this for the next release candidate/final 1.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus.
Projects
None yet
Development

No branches or pull requests

2 participants