-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub code owners for the specification #341
Comments
An alternative proposal would be to increase the number of required reviews (currently 2). However, this would not prevent "gangs" from pushing their proposals 😉, only make that somewhat harder. |
Coming back to this idea, I think this would be a nice way of handling the It would probably make sense to have the "nominated" release managers for each release as required reviewers for the final PR to |
I raised in the last meeting that it might make sense to add GitHub "code owners" to the
optimade.rst
file, which are required to review any PRs before merging (instead of the scattergun approach we take at the moment, where the PR author has to choose from a list of 50 people).This artificially elevates some members of the community, but currently we are vulnerable to features getting pushed through without consensus.
This would simply require creation of a CODEOWNERS file under
.github/
following https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-ownersThis could even be split down by branch (slightly awkwardly requires different CODEOWNERS files on each branch) so that "fixes" to whatever branch ends up tracking v1.0.x (see #340) only requires 1 or 2 reviewers, whereas new features could require multiple code owners to agree (say 1 per major implementation).
There would obviously be an acceptance that new features are therefore dealt with much more slowly.
The text was updated successfully, but these errors were encountered: