Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPTIMADE version as an action parameter #66

Open
ml-evs opened this issue Jul 7, 2021 · 1 comment
Open

Add OPTIMADE version as an action parameter #66

ml-evs opened this issue Jul 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ml-evs
Copy link
Member

ml-evs commented Jul 7, 2021

As optimade-python-tools "latest" (v0.16.0) now tracks v1.1 of the OPTIMADE spec, setting all_versioned_paths to true now tests /v1.1 URLs. As well as the validator_version option, it could be useful to add optimade_version so that people can still use the validator action for v1.0.0. This will require a map from optimade-python-tools versions -> optimade version, so e.g. specifyting optimade_version: 1.0.0 will install the last supported OPT, v0.15.5.

@CasperWA
Copy link
Member

CasperWA commented Jul 7, 2021

I think I mentioned this at some point as well? Edit: Yup, this is #59. But let's make this supersede it.

Either we make it completely dynamic, crawling the github tags to try and determine the latest version with a desired version. But more practically I think we should find a way to make a bit "easier" to implement here? Maybe going as far as a static file. The issue there of course being that we'd need to update it everytime a new version is released of optimade.
Maybe we can make an action that does this? Either here or in the optimade-python-tools repo? I don't know.

@CasperWA CasperWA added the enhancement New feature or request label Jul 7, 2021
@CasperWA CasperWA changed the title Add OPTIMADE version is an action parameter Add OPTIMADE version as an action parameter Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants