-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Calcified fraction (possibly) not calculated correctly in standard_volume_update_function
#133
Comments
Going by equation 37 in supplemental information 1 of PhysiCell's paper the intention was for the equation to read
|
Addressed in Pull Request #134 |
@JulianoGianlupi thank you so much!! This is a very good catch! (And we need to catch up, by the way!) I'll make sure this gets folded into PhysiCell 1.11.0. |
Actually, i want to take a closer look ... This is the line (Line 548) that adds the extra calcification:
|
Will now be fixed in 1.11.0, thanks to you!! |
In
PhysiCell_standard_models.cpp
'sstandard_volume_update_function
I believe the calcified fraction update is not correct. All dynamic volumes except it are updated following a forward Euler method, e.g.phenotype.volume.fluid += dt * phenotype.volume.fluid_change_rate * ( phenotype.volume.target_fluid_fraction * phenotype.volume.total - phenotype.volume.fluid );
The calcified fraction update does not have the
+
in the+=
. It readsphenotype.volume.calcified_fraction = dt * phenotype.volume.calcification_rate * (1- phenotype.volume.calcified_fraction);
This means the cell will never calcify completely, it's calcified fraction will fluctuate around
dt * phenotype.volume.calcification_rate
The text was updated successfully, but these errors were encountered: