Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg dependency #5

Closed
jdmoorman opened this issue Dec 16, 2020 · 2 comments
Closed

ffmpeg dependency #5

jdmoorman opened this issue Dec 16, 2020 · 2 comments

Comments

@jdmoorman
Copy link

The ffmpeg dependency mentioned in the README is not the same as the ffmpeg requirement listed in setup.py on line 28. The ffmpeg requirement listed in setup.py is actually https://pypi.org/project/ffmpeg/. There is a Python wrapper for ffmpeg called ffmpy that you might be able to use, or you can link to ffmpeg.org so users know where to download ffmpeg. In any case, ffmpeg should be removed from the requirements list in setup.py.
@jdmoorman
Copy link
Author

openjournals/joss-reviews#2862

@mengaldo
Copy link
Collaborator

mengaldo commented Mar 1, 2021

@jdmoorman This should now be fixed, thank you.

@mengaldo mengaldo closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mengaldo @jdmoorman