Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please help me some key questions #11

Open
Ultraman6 opened this issue Oct 14, 2024 · 1 comment
Open

please help me some key questions #11

Ultraman6 opened this issue Oct 14, 2024 · 1 comment

Comments

@Ultraman6
Copy link

I see the fine-tune of lora implementions in your code is only tune the parameters of image-encoder in sam, if it is important to take adaptation of downstream prompt encoder and mask decoder in sam?
why I try to expand the fine-tune to those block, but the result shows like that
image
image
Is the period of training should be longer than that of fine-tune of only lora?

@MathieuNlp
Copy link
Owner

Hello,

You are right, my implementation adapt the encoder only. I tought that it would be wise to adapt the feature extractor which is the encoder. I believe that adapting the mask decoder would make similar results so I don't understand why the results are like this.

For the prompt encoder, I am not sure if it is necessary to adapt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants