Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing via upm/git spams warnings due to sample games' scripts #50

Closed
johanhelsing opened this issue Aug 26, 2022 · 0 comments
Closed

Comments

@johanhelsing
Copy link

johanhelsing commented Aug 26, 2022

Describe the bug

Whenever I open my project or recompilation of zenject is triggered, I several screens of warnings from extenject.

This makes it harder to spot real problems in my repo.

To Reproduce

Open a fresh unity project.

Add extenject as a upm git dependency:

Wait for import and watch 54 warnings appear in the console.

    "com.svermeulen.extenject": "https://github.com/Mathijs-Bakker/Extenject.git?path=/UnityProject/Assets/Plugins/Zenject",

These warnings re-appear on certain times when I develop without actually touching extenject. I'm not sure exactly why/when Unity sometimes decides to reimport extenject.

Expected behavior

A clean import with no warnings.

Screenshots

image

Extenject and Unity info (please complete the following information):

  • Zenject version: 5d39c2f
  • Unity version: 2021.3.8

I made an attempt to fix this here: modesttree#220

It kind of stalled because maybe it broke asset store and or .unitypackage installation of samples and I didn't have the time to investigate and fix potential issues for a build system I was not going to use anyway.

However a lot has happened since then. The original svermeulen/extenject repo and its PRs was hijacked by modesttree after the lawsuit and then the zenject project was once again abandoned.

I'm not sure if all 4 installation options listed in the readme are still supported? It would certainly make fixing this issue a lot easier if we can drop the asset store path and focus on the upm distribution only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants